Date: Tue, 6 Dec 2016 09:35:33 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309627 - head/contrib/netbsd-tests/lib/libc/locale Message-ID: <1EA4A689-5DE5-4B6D-95BC-96C9430B41A3@gmail.com> In-Reply-To: <201612061706.uB6H6EKM076438@repo.freebsd.org> References: <201612061706.uB6H6EKM076438@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Dec 6, 2016, at 09:06, Bryan Drewery <bdrewery@FreeBSD.org> wrote: > > Author: bdrewery > Date: Tue Dec 6 17:06:14 2016 > New Revision: 309627 > URL: https://svnweb.freebsd.org/changeset/base/309627 > > Log: > Remove unneeded hack fixed by r309626. > > strvis(3) being tainted by our mbtowc(3) calls was causing > spurious failures here. > > MFC after: 2 weeks > Sponsored by: Dell EMC Isilon > > Modified: > head/contrib/netbsd-tests/lib/libc/locale/t_mbtowc.c > > Modified: head/contrib/netbsd-tests/lib/libc/locale/t_mbtowc.c > ============================================================================== > --- head/contrib/netbsd-tests/lib/libc/locale/t_mbtowc.c Tue Dec 6 17:05:02 2016 (r309626) > +++ head/contrib/netbsd-tests/lib/libc/locale/t_mbtowc.c Tue Dec 6 17:06:14 2016 (r309627) > @@ -137,16 +137,10 @@ ATF_TC_BODY(mbtowc, tc) > h_mbtowc("ja_JP.ISO2022-JP", "\033$B", "\033$B$\"\033(B"); > h_mbtowc("ja_JP.SJIS", "\202", "\202\240"); > h_mbtowc("ja_JP.eucJP", "\244", "\244\242"); > -#ifndef __FreeBSD__ > /* Moved last as it fails */ > h_mbtowc("zh_CN.GB18030", "\241", "\241\241"); > -#endif > h_mbtowc("zh_TW.Big5", "\241", "\241@"); > h_mbtowc("zh_TW.eucTW", "\241", "\241\241"); > -#ifdef __FreeBSD__ > - atf_tc_expect_fail("zh_CN.GB18030"); > - h_mbtowc("zh_CN.GB18030", "\241", "\241\241"); > -#endif > } It’s interesting how we always hit this at $work, but upstream has never hit this once AFAIK. -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYRvblAAoJEPWDqSZpMIYVP4oP/i2Cx9psvWTcqTKY/UTfYMdP lI+DjGBgXXuKWUhbEk4d8XHgzrR7+t1v0fvp9e2Igz2vQz5BVaawIwvKHpVxv6yJ Clixjq4CL+AAJDehwAHyimdsKPIKuCTp5HT6J11iYsuNL788LJ9iWwW7n6a50T6o Q0TIXZnpGh+MR64oFbBHwXBLboJ8klKlihR3/jHa8wBoC319BpbeXkUxoFXPI/oD WksJO3W0/ZfGmzSGVh47US+06Qzst+WIoBzLhnSbfTxoXF5qafw2HpLXYri2dinh rIrJ/Q97f+4OU0jhrlSs5kkGHF0EzX7gfi4Ir+Yly2s9vMnjNgTn3jUlHfPgP8VA 4EFJBAoPwPpRFEwP/ovF2baXybr+L1YdA5WAPlNx22VKTxR1kWYUqvJ6J2I09vM5 SuBhj62cTGjACBoOGwbf9mIm8meEHD0g25p90g+waKq4QMgCkDONSiaHOr79QMMw /OpH0t42xRC6dyACJr7hk45JB2ug5Wvxm+1ARdswqmPq9rRGEQBre8VcrQJH+Ly1 OMsTSU/gZwHvB1XwGPMJ+o3tActXKv3jZxnhbUl0lRQ87cDvbMCxDTV0YvRpFD4L M9TtcSFMlcrQYrHdNEz9FPkTaP1wGupCbUEtEsUBVmMTDpX8DqE9KbVEqv0U3AEv hCwzEAJ7L0Q5Zi42YOSQ =30YW -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1EA4A689-5DE5-4B6D-95BC-96C9430B41A3>