Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Mar 2001 12:42:49 -0500
From:      Michael Lucas <mwlucas@blackhelicopters.org>
To:        hackers@freebsd.org
Subject:   context or unified diffs in PRs?
Message-ID:  <20010310124249.A87381@blackhelicopters.org>

next in thread | raw e-mail | index | archive | help
Hello,

I'm afraid I might be walking up to a bikeshed with a can of paint
here, but the flood of email in the last twenty-four hours has
convinced me to ask.

In an article O'Reilly published yesterday, I stated (per the
Handbook) that context diffs were the correct way to submit patches
with PRs.  I've had several people claim that unified diffs are the
way to go, and that the handbook is just wrong.

Is the Handbook correct, or are unified diffs preferred?  I'll be
happy to fix my article and submit a PR to correct the Handbook if
this is the case.

Thanks,
Michael

-- 
Michael Lucas
mwlucas@blackhelicopters.org
http://www.blackhelicopters.org/~mwlucas/
Big Scary Daemons: http://www.oreillynet.com/pub/q/Big_Scary_Daemons

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010310124249.A87381>