Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Jan 2012 13:53:53 +0200
From:      Mikolaj Golub <trociny@freebsd.org>
To:        Kevin Lo <kevlo@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r230208 - head/sys/fs/tmpfs
Message-ID:  <86mx9nsw1a.fsf@in138.ua3>
In-Reply-To: <201201161025.q0GAPNDq027693@svn.freebsd.org> (Kevin Lo's message of "Mon, 16 Jan 2012 10:25:23 %2B0000 (UTC)")
References:  <201201161025.q0GAPNDq027693@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Mon, 16 Jan 2012 10:25:23 +0000 (UTC) Kevin Lo wrote:

 KL> Author: kevlo
 KL> Date: Mon Jan 16 10:25:22 2012
 KL> New Revision: 230208
 KL> URL: http://svn.freebsd.org/changeset/base/230208

 KL> Log:
 KL>   Add nfs export support to tmpfs(5)
 KL>   
 KL>   Reviewed by:        kib

 KL> Modified:
 KL>   head/sys/fs/tmpfs/tmpfs_vfsops.c

 KL> Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c
 KL> ==============================================================================
 KL> --- head/sys/fs/tmpfs/tmpfs_vfsops.c        Mon Jan 16 09:53:24 2012        (r230207)
 KL> +++ head/sys/fs/tmpfs/tmpfs_vfsops.c        Mon Jan 16 10:25:22 2012        (r230208)
 KL> @@ -150,10 +150,8 @@ tmpfs_mount(struct mount *mp)
 KL>                  return (EINVAL);
 KL>  
 KL>          if (mp->mnt_flag & MNT_UPDATE) {
 KL> -                /* XXX: There is no support yet to update file system
 KL> -                 * settings.  Should be added. */
 KL> -
 KL> -                return EOPNOTSUPP;
 KL> +                if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0))
 KL> +                        return (0);

Shouldn't we still return EOPNOTSUPP here?

 KL>          }
 KL>  
 KL>          vn_lock(mp->mnt_vnodecovered, LK_SHARED | LK_RETRY);

-- 
Mikolaj Golub



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86mx9nsw1a.fsf>