Date: Tue, 20 Mar 2012 22:27:03 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Davide Italiano <davide.italiano@gmail.com> Cc: svn-src-head@FreeBSD.org, George Neville-Neil <gnn@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r233045 - in head/sys: conf kern Message-ID: <20120320182703.GJ30704@FreeBSD.org> In-Reply-To: <CACYV=-Fpm%2B3jYZc31DswSzj=ccWdYMnYrDSU5-6K=XwmZY9neA@mail.gmail.com> References: <201203162032.q2GKWBRV033715@svn.freebsd.org> <20120319194431.GD30704@FreeBSD.org> <CACYV=-EmbDNep1rPwF6jfHB2M8JuhLDFvrsvZoBMuVB7kOC1bA@mail.gmail.com> <CACYV=-HnKmkcw-p2i9o_VyKGkp6V5yzO0B61uCBOAebg=VHd-A@mail.gmail.com> <20120320143611.GH30704@FreeBSD.org> <CACYV=-Fpm%2B3jYZc31DswSzj=ccWdYMnYrDSU5-6K=XwmZY9neA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 20, 2012 at 06:00:50PM +0100, Davide Italiano wrote: D> 2012/3/20 Gleb Smirnoff <glebius@freebsd.org>: D> > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: D> > D> >> These indented ifdefs look like a major violation of style used throughout D> > D> >> the FreeBSD kernel code. Can you please keep with common style? D> > D> >> D> > D> > D> > D> > Heh, D> > D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and D> > D> > after I'll have approval from my mentor I'll commit. D> > D> > Looks okay, apart from additional empty line in NOTES. Isn't single D> > empty line enough? D> > D> > -- D> > Totus tuus, Glebius. D> D> Well, I removed that in my previous commit. D> It was a mistake. D> But if you think it's ok to remove that line, I have no objections on this. Well, I'm not that style(9)-evident person :) I just personally dislike multiple empty lines, since less code fits on a terminal. So I won't insist on any choice here. I just noticed incorrect indentation of ifdefs, and that's all. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120320182703.GJ30704>