Date: Tue, 10 Jul 2007 18:56:06 +0200
From: Ed Schouten <ed@fxq.nl>
To: FreeBSD Current <freebsd-current@freebsd.org>
Subject: D_NEEDGIANT usage in {amd64,i386}/isa/clock.c
Message-ID: <20070710165606.GE55449@hoeg.nl>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hello, I was just taking a look at the /dev/nvram code in the isa/clock.c files of the amd64 and i386 architectures. For some reason, the "nvram" device needs D_NEEDGIANT. If I take a look at the nvram_open(), nvram_read() and nvram_write() routines, I see no reason why it should be marked D_NEEDGIANT. Both the nvram_read() and nvram_write() routines both perform some simple bounds checking and then call rtcin() and writertc(). Both of those routines are already protected from concurrent access through the RTC_LOCK and RTC_UNLOCK macro's. Yours, -- Ed Schouten <ed@fxq.nl> WWW: http://g-rave.nl/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGk7om52SDGA2eCwURAneSAJ4mSLmFkGeG7p+CI/L2nB0Z3iN+WACfbFmQ qMlOePLlwpnjE1977k5SKPY= =c9MT -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070710165606.GE55449>