Date: Sat, 3 Feb 2024 12:32:21 +0100 From: Luca Pizzamiglio <pizzamig@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: Max Brazhnikov <makc@freebsd.org>, Charlie Li <vishwin@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, portmgr@freebsd.org Subject: Re: git: 06dbf1df62a4 - main - audio/alsa-plugins: convert options to subpackages Message-ID: <CAB88xy_T%2Bh=%2BKF=7yTmLsxQ0ooRDOz8-AxnsxvRpGaSA6-f%2BrA@mail.gmail.com> In-Reply-To: <8r41-95wd-wny@FreeBSD.org> References: <202402021346.412DkSeX016477@gitrepo.freebsd.org> <23b873e3-051e-4d3e-8f66-21bbc57783bc@freebsd.org> <il36-axp7-wny@FreeBSD.org> <4018119.BRNeRiNLvY@mercury> <8r41-95wd-wny@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] I would stop adding more subpackages, until we have fixed those small annoying bugs. Dogfooding has already surfaced a few issues, so it's time to fix those issues before adding more stuff. On Sat, Feb 3, 2024 at 11:52 AM Jan Beich <jbeich@freebsd.org> wrote: > Max Brazhnikov <makc@freebsd.org> writes: > > > On Sat, 03 Feb 2024 07:06:28 +0100 Jan Beich wrote: > > > >> Charlie Li <vishwin@freebsd.org> writes: > >> > >> > Jan Beich wrote: > >> > > >> >> The branch main has been updated by jbeich: > >> >> URL: > >> >> > https://cgit.FreeBSD.org/ports/commit/?id=06dbf1df62a4f54da4cadecbbc0be5f33902eb1c > >> >> commit 06dbf1df62a4f54da4cadecbbc0be5f33902eb1c > >> >> Author: Jan Beich <jbeich@FreeBSD.org> > >> >> AuthorDate: 2024-01-30 16:18:28 +0000 > >> >> Commit: Jan Beich <jbeich@FreeBSD.org> > >> >> CommitDate: 2024-02-02 13:44:56 +0000 > >> >> audio/alsa-plugins: convert options to subpackages > >> >> Reduce heavy dependencies for consumers e.g., > >> >> - chromium -> pipewire -> alsa-plugins -> pulseaudio > >> >> - wine -> alsa-plugins -> pulseaudio > >> >> > >> > At least my poudriere wants to delete and rebuild every run because it > >> > thinks a new dependency is always missing. > >> > >> See https://github.com/freebsd/poudriere/issues/1113 > > > > Can we please stop adding new subpackages until this issue is fixed? > > - this change has high ROI: disable PULSEAUDIO by default vs. "batteries > included" > - not much of an issue for the package cluster due to high churn on > /latest set > - shouldn't impact unsupervised or portmsater builds (options are still > there) > - SUBPACKAGES require dogfooding[1] to test tools and avoid regressions > > [1] https://reviews.freebsd.org/D43079 was far too simple > https://reviews.freebsd.org/D43445 was actually incorrect > [-- Attachment #2 --] <div dir="ltr"><div>I would stop adding more subpackages, until we have fixed those small annoying bugs.</div><div>Dogfooding has already surfaced a few issues, so it's time to fix those issues before adding more stuff.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 3, 2024 at 11:52 AM Jan Beich <<a href="mailto:jbeich@freebsd.org">jbeich@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Max Brazhnikov <<a href="mailto:makc@freebsd.org" target="_blank">makc@freebsd.org</a>> writes:<br> <br> > On Sat, 03 Feb 2024 07:06:28 +0100 Jan Beich wrote:<br> ><br> >> Charlie Li <<a href="mailto:vishwin@freebsd.org" target="_blank">vishwin@freebsd.org</a>> writes:<br> >> <br> >> > Jan Beich wrote:<br> >> ><br> >> >> The branch main has been updated by jbeich:<br> >> >> URL:<br> >> >> <a href="https://cgit.FreeBSD.org/ports/commit/?id=06dbf1df62a4f54da4cadecbbc0be5f33902eb1c" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=06dbf1df62a4f54da4cadecbbc0be5f33902eb1c</a><br>; >> >> commit 06dbf1df62a4f54da4cadecbbc0be5f33902eb1c<br> >> >> Author: Jan Beich <jbeich@FreeBSD.org><br> >> >> AuthorDate: 2024-01-30 16:18:28 +0000<br> >> >> Commit: Jan Beich <jbeich@FreeBSD.org><br> >> >> CommitDate: 2024-02-02 13:44:56 +0000<br> >> >> audio/alsa-plugins: convert options to subpackages<br> >> >> Reduce heavy dependencies for consumers e.g.,<br> >> >> - chromium -> pipewire -> alsa-plugins -> pulseaudio<br> >> >> - wine -> alsa-plugins -> pulseaudio<br> >> >> <br> >> > At least my poudriere wants to delete and rebuild every run because it<br> >> > thinks a new dependency is always missing.<br> >> <br> >> See <a href="https://github.com/freebsd/poudriere/issues/1113" rel="noreferrer" target="_blank">https://github.com/freebsd/poudriere/issues/1113</a><br>; ><br> > Can we please stop adding new subpackages until this issue is fixed?<br> <br> - this change has high ROI: disable PULSEAUDIO by default vs. "batteries included"<br> - not much of an issue for the package cluster due to high churn on /latest set<br> - shouldn't impact unsupervised or portmsater builds (options are still there)<br> - SUBPACKAGES require dogfooding[1] to test tools and avoid regressions<br> <br> [1] <a href="https://reviews.freebsd.org/D43079" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D43079</a>; was far too simple<br> <a href="https://reviews.freebsd.org/D43445" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D43445</a>; was actually incorrect<br> </blockquote></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAB88xy_T%2Bh=%2BKF=7yTmLsxQ0ooRDOz8-AxnsxvRpGaSA6-f%2BrA>