Date: Thu, 27 Aug 2015 00:08:19 +0200 From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <dumbbell@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, Baptiste Daroussin <bapt@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287174 - head/sys/dev/drm2/i915 Message-ID: <55DE38D3.9000802@FreeBSD.org> In-Reply-To: <20150826215311.GF2072@kib.kiev.ua> References: <201508262135.t7QLZGs7067675@repo.freebsd.org> <20150826215311.GF2072@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 26.08.2015 23:53, Konstantin Belousov wrote:
> On Wed, Aug 26, 2015 at 09:35:16PM +0000, Baptiste Daroussin wrote:
>> -static bool
>> +static inline bool
>> i915_gem_object_is_inactive(struct drm_i915_gem_object *obj)
>> {
>> -
>> - return !obj->active;
>> + return obj->gtt_space && !obj->active;
>
> Why is this correct ?
obj->gtt_space is NULL when the object is not mapped in the global GTT.
This check was added in 6c085a728cf000ac1865d66f8c9b52935558b328
("drm/i915: Track unbound pages"), first released in Linux 3.7.
But now that I think of it again, it may not be correct with the current
driver (and only correct in the context of a 3.8-era driver).
Baptiste, could you please revert that part?
--=20
Jean-S=E9bastien P=E9dron
--JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJV3jjYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz
OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMWpUQAIDrMeaZpbm2sHif6Hos2rVE
2hIsVuNGyfq+SINnJgMLM2azhHy43iRpLmhpa9cNirWGQ2yqVmYnXsEsQib507ak
D+SWkesp9Rq1Ov3FwMNLr1kFefkBpzsDNf/O986xXvnwn69i9/tScfwTvBNMjLGx
lpAlIuW8GN848hO3R/zBk6XRlvNfa0hwC5A2xWv2oZBmLO1gYlhn8HHdpUSlv40U
KGmTnbt3PaatCvxiXPXsE0oZNnqKQEUeLmfiPO2kaN5YxhNiVbRRvVhOyghFBlhU
KpEbRPOtXDeS6V7PEGGgnX7eceOJOr6aW6jBFcWOUksexgUngZRQFbP7hLRXiDyS
g64w7MJZFIVROJ3aX35TX3MYSRDq1FzXYWwJ0hGzaLIp86zCS+EQZ06m9y0C8xjU
bW0ZCCBJ9VB7Wtuf6fh6Cd+KbWJ2bIWVNkJkYJPQvmUoSOeZHNnq1SRDBmiTD3BN
B2k5r/dwILsi3VT0w0/C7sxOVfmTGUyDHvPTQbZsJedHoSgxqsgWW6aXglDbYCQV
ZfFYjUluv8uNF7H6zO2iiLbvqyStIEhSlGbFXF24+2/3vWgip548xQcuHotezaal
ALL5jKw3DMtDwFCy40Az1oV2OzESHbP9vH9NSdXBQP+ngySkZWRfUAZ54bF2VaVb
s+XWyATdI6wUmgOzJ+9o
=6eac
-----END PGP SIGNATURE-----
--JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55DE38D3.9000802>