Date: Mon, 5 Mar 2018 10:25:40 -0500 From: Ash Gokhale <ashfixit@gmail.com> To: Josh Paetzel <josh@tcbug.org> Cc: Kurt Jaeger <pi@opsec.eu>, Kurt Jaeger <lists@opsec.eu>, Diane Bruce <db@db.net>, freebsd-ports@freebsd.org Subject: Re: net/viamillipede seeks commiter Message-ID: <CAHpe%2B0ZzP3BBDHTBMnLRoOtF4YreSh=FfF0vCarVa9VANtz0BQ@mail.gmail.com> In-Reply-To: <1520182718.1126475.1291006864.4F744B98@webmail.messagingengine.com> References: <CAHpe%2B0b6-nxm5o7kvvzVG=7zpo1mRU6ns7vWRUF750b8-qv2Hg@mail.gmail.com> <20180303044839.GA32429@home.opsec.eu> <5A9A2A97.5090401@grosbein.net> <20180303050654.GB32429@home.opsec.eu> <1520059234.309443.1289947728.44653321@webmail.messagingengine.com> <20180303080634.GC32429@home.opsec.eu> <CAHpe%2B0awr0zL9Tp0=CKt3nLK4BQdKFEGk3qwPvjkboeeogPONA@mail.gmail.com> <B271493C-591B-4FDC-98A3-3B11CB2262BD@tcbug.org> <CAHpe%2B0a8vNKYxhT=p6OOUgbKtpFqEdmjSrsP_tFo3J5Sx9PUdg@mail.gmail.com> <20180303185149.GD32429@home.opsec.eu> <1520182718.1126475.1291006864.4F744B98@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 4, 2018 at 11:58 AM, Josh Paetzel <josh@tcbug.org> wrote:
>
>
> On Sat, Mar 3, 2018, at 12:51 PM, Kurt Jaeger wrote:
>
> > --
> > pi@opsec.eu +49 171 3101372 2 years
> to go !
>
> I get a different failure on 10.4 using poudriere:
>
> --- rx.o ---
> rx.c:182:14: error: expected ')'
> (void *(* _Nonnull)(void *))&rxworker,
> ^
> rx.c:182:11: note: to match this '('
> (void *(* _Nonnull)(void *))&rxworker,
> ^
> 1 error generated.
> --- tx.o ---
> tx.c:317:14: error: expected ')'
> (void *(* _Nonnull)(void *))&txworker_sm,
> ^
> tx.c:317:11: note: to match this '('
> (void *(* _Nonnull)(void *))&txworker_sm,
> ^
> 1 error generated.
> *** [tx.o] Error code 1
>
> I have a small Makefile patch I'll send as a pull request to satisfy
> portlint.
>
> --
>
> Thanks,
>
> Josh Paetzel
>
The nonnull attrib error is a thing to ponder nice to save those two
instructions:
http://rachid.koucha.free.fr/tech_corner/nonnull_gcc_attribute.html.
Looks like we got it here https://reviews.freebsd.org/D2101
And clang suggested a change that I complicitly copied without
understanding the portability damage.
What's the portable way to murder all the typing and shut up the compiler
warnings?
Is there a correct way to indicate the correct types through the pthreads
interfaces?
I'm also open to suggestions for a minimal makefile that satisfies the
build discipline. The tool itself doesn't need anything except sockets and
stdio. Future work would cap limit this, but it's not really portable yet.
And thanks for the portlint PR while I learn the poudriere.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHpe%2B0ZzP3BBDHTBMnLRoOtF4YreSh=FfF0vCarVa9VANtz0BQ>