Date: Mon, 14 Nov 2005 16:14:20 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bill Paul <wpaul@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_arcsubr.c if_arp.h if_bridge.c if_ef.c if_ethersubr.c if_fddisubr.c if_fwsubr.c if_iso88 Message-ID: <20051114141420.GW87446@ip.net.ua> In-Reply-To: <20051113212345.330A316A420@hub.freebsd.org> References: <200511111604.jABG4xw3011845@repoman.freebsd.org> <20051113212345.330A316A420@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--BcZrms9gUsdgyR6a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bill, On Sun, Nov 13, 2005 at 09:23:45PM +0000, Bill Paul wrote: > [...] >=20 > > sys/compat/ndis subr_ndis.c=20 >=20 > [...] >=20 > > - Store pointer to the link-level address right in "struct ifnet" > > rather than in ifindex_table[]; all (except one) accesses are > > through ifp anyway. IF_LLADDR() works faster, and all (except > > one) ifaddr_byindex() users were converted to use ifp->if_addr. > > =20 > > - Stop storing a (pointer to) Ethernet address in "struct arpcom", > > and drop the IFP2ENADDR() macro; all users have been converted > > to use IF_LLADDR() instead. >=20 > For the umpity umpth time: I'm trying to keep it so that the same > NDIS code will compile on 7.x, 6.x and 5.x. Having one set of code > means I don't need to go nuts doing merges from one branch to the > next: I can just pull the files over and be done with it. >=20 Understood. > You did > not consider this when modifying subr_ndis.c, and now you have broken > it for the 6.x and 5.x branches. >=20 Yes I did. > More importantly, you broke it in > a very subtle way that only shows up as a kernel panic a runtime. >=20 Can you please give me more details about this panic? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --BcZrms9gUsdgyR6a Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDeJu7qRfpzJluFF4RAgcXAKCWHQA6jNIhDKlSaUC3X4Nm2esmlwCfd/mD 2c8Vmfr6RPJaICMKIb3ZSl4= =GeQQ -----END PGP SIGNATURE----- --BcZrms9gUsdgyR6a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051114141420.GW87446>