Date: Mon, 02 Sep 2002 06:06:09 -0700 From: Peter Wemm <peter@wemm.org> To: David O'Brien <obrien@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile src/usr.bin/make Makefile Message-ID: <20020902130609.1F5A52A893@canning.wemm.org> In-Reply-To: <20020901180827.GA33541@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"David O'Brien" wrote:
> On Sat, Aug 31, 2002 at 12:18:40AM -0700, Peter Wemm wrote:
> > Modified files:
> > . Makefile
> > usr.bin/make Makefile
> > Log:
> > Deal with bootstrapping from an old -current (almost exactly a year old)
> > which fails the make tests (doesn't understand ${notdef:U}) and therefore
> > fails on __FBSDID in usr.bin/make/*. -DBOOTSTRAPPING is no help here sin
ce
> > this is before we are using the new share/mk/* files, and it would confli
ct
> > with the builtin -DBOOTSTRAPPING support later.. so use a different flag.
> >
> > Revision Changes Path
> > 1.264 +2 -1 src/Makefile
> > http://cvsweb.freebsd.org/src/Makefile.diff?r1=1.263&r2=1.264
> > 1.26 +3 -0 src/usr.bin/make/Makefile
> > http://cvsweb.freebsd.org/src/usr.bin/make/Makefile.diff?r1=1.25&r2=1.26
>
> I thought we were going to impliment these warts with some form of
> __FreeBSD_version test -- so they don't impact source bases that don't
> need them, and more importantly so it is documented the time range they
> cover so we know when to remove them.
Go for your life. Personally, I think that this sort of stuff should be
removed from critical bootstrap tools with extreme prejudice.
Next problem: make has got /bin/sh hardcoded by absolute path. This burns
us during an 4.x->5.x upgrade when /bin/sh is replaced before make has
finished running things and the freshly installed /bin/sh gets a SIGSYS on
eaccess(2). If that is solved, then we can avoid one reboot.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020902130609.1F5A52A893>