Date: Thu, 07 Feb 2008 17:55:00 +0200 From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-hardware@freebsd.org, freebsd-stable@freebsd.org, freebsd-current@freebsd.org Subject: Re: ps/2 mouse patch [intellimouse explorer detection] Message-ID: <47AB29D4.1040409@icyb.net.ua> In-Reply-To: <47A738AE.5070900@icyb.net.ua> References: <4799D78F.6000405@icyb.net.ua> <47A097FA.3090303@icyb.net.ua> <20080130164508.GC6257@suse.cz> <47A2E7E5.1040307@icyb.net.ua> <20080201093806.GA4632@suse.cz> <47A738AE.5070900@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Still nobody comes forward. Is there any maintainer of psm driver? As a final authority I am forced to quote now Microsoft itself on this matter: http://www.microsoft.com/whdc/device/input/5b_wheel.mspx I've also found a PR for the similar hardware from the same vendor with the same symptoms: http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/118578 I am moving this discussion there now, but knowing how the PRs are handled for the bits without a maintainer or with very-low-activity maintainer[*], this is a cry of hope and desperation. [*] - Well, I know that I am talking about very old code, for very old protocol where things should have long been settled. But apparently there are cases when the code works in 99% of cases and nobody cares about the rest 1%, even if that percent is not some quirky hardware, but the hardware that does follows its specification, only too rigidly. on 04/02/2008 18:09 Andriy Gapon said the following: > on 01/02/2008 11:38 Vojtech Pavlik said the following: >> On Fri, Feb 01, 2008 at 11:35:33AM +0200, Andriy Gapon wrote: >>> I compared FreeBSD and Linux sources more thoroughly and found the >>> following: >>> http://lxr.linux.no/linux+v2.6.24/drivers/input/mouse/psmouse-base.c#L464 >>> static int im_explorer_detect(struct psmouse *psmouse, int set_properties) >>> { >>> struct ps2dev *ps2dev = &psmouse->ps2dev; >>> unsigned char param[2]; >>> >>> intellimouse_detect(psmouse, 0); >>> >>> I.e., first thing the explorer probe does is massaging a mouse with >>> IntelliMouse magic commands. >>> >>> I did the same in FreeBSD psm.c, i.e., added a call to >>> enable_msintelli() at the very start of enable_msexplorer(). And voilą - >>> everything is perfect, correct ID is returned, probing succeeds, the >>> mouse works great. >>> >>> I think that this change is quite safe to make in FreeBSD, because with >>> Linux user-base we can be 99% percent sure that this change won't break >>> anything. >> It is even correct: A mouse isn't required to be able to jump straight >> into the Explorer mode, it is supposed to always go through the >> IntelliMouse mode. > > Any takers to test this change with your current PS/2 mouse (either > working or non-working) ? > Any takers to commit this change ? :-) > > Will this issue get more traction if I file a PR? > > > -- Andriy Gapon _______________________________________________ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47AB29D4.1040409>