Date: Fri, 1 Mar 2024 21:43:29 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: Gleb Popov <arrowd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob. Message-ID: <ocssh5s2p3dyymwcaktwld5wrezefeyfdomqdydtd7sjuuayst@5w36rxkjky65> In-Reply-To: <ab6429b3b2004cd8ad9e7ed0b563a5c9@mail.infomaniak.com> References: <202403011927.421JRqxx065749@gitrepo.freebsd.org> <ab6429b3b2004cd8ad9e7ed0b563a5c9@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 01, 2024 at 09:20:51PM +0100, Daniel Engberg wrote: > On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org> > wrote: > > > The branch main has been updated by arrowd: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=c2afef5c2587738b16b52def34edcebe4e421905 > > > > commit c2afef5c2587738b16b52def34edcebe4e421905 > > > > Author: Gleb Popov <arrowd@FreeBSD.org> > > > > AuthorDate: 2024-03-01 19:25:37 +0000 > > > > Commit: Gleb Popov <arrowd@FreeBSD.org> > > > > CommitDate: 2024-03-01 19:26:53 +0000 > > > > Features/testing.mk [http://testing.mk]: Introduce the TESTING_UNSAFE knob. > > > > > > > > Approved by: tcberner > > > > --- > > > > Mk/Features/testing.mk [http://testing.mk] | 5 ++++- > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Mk/Features/testing.mk [http://testing.mk] b/Mk/Features/testing.mk [http://testing.mk] > > > > index 15af7e28eb7c..a266f6effe91 100644 > > > > --- a/Mk/Features/testing.mk [http://testing.mk] > > > > +++ b/Mk/Features/testing.mk [http://testing.mk] > > > > @@ -4,12 +4,15 @@ > > > > # - If set, and the port supports it, the software's test suite will be compiled > > > > # and run during the normal building pipeline between 'stage' and 'package' > > > > # stages. > > > > +# - A port may define TESTING_UNSAFE=yes if its tests are known to fail at the > > > > +# moment. > > > > > > > > .if !defined(_TESTING_MK_INCLUDED) > > > > _TESTING_MK_INCLUDED= yes > > > > TESTING_Include_MAINTAINER= portmgr@FreeBSD.org > > > > > > > > +. if !defined(TESTING_UNSAFE) > > > > _TESTING_PACKAGE_DEP= test > > > > +. endif > > > > > > > > .endif > > > > - > > Hi, > > Thanks for adding this, however this won't work on ports that uses > TEST menu option as far as I can tell which is a relatively common > occurence? > > Se also > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495 > > Best regards, > > Daniel > > In my opinion it should disappear in favor of the feature which clearly makes more sense. Best regards, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ocssh5s2p3dyymwcaktwld5wrezefeyfdomqdydtd7sjuuayst>