Date: Mon, 8 May 2017 11:46:20 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317744 - in head/usr.sbin/makefs: . ffs Message-ID: <980BBC93-4004-4036-BEF4-3C58DB23BED6@gmail.com> In-Reply-To: <AA887004-E370-41CB-A4CF-9F3810BA072E@gmail.com> References: <201705031421.v43ELIP9093367@repo.freebsd.org> <AA887004-E370-41CB-A4CF-9F3810BA072E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On May 8, 2017, at 11:24, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> >> On May 3, 2017, at 07:21, Ed Maste <emaste@freebsd.org> wrote: >> >> Author: emaste >> Date: Wed May 3 14:21:18 2017 >> New Revision: 317744 >> URL: https://svnweb.freebsd.org/changeset/base/317744 >> >> Log: >> makefs: make buf generic >> >> it has nothing to do with ffs and will eventually be moved. >> gc sectorsize. >> >> NetBSD versions: >> ffs.c 1.58 >> ffs/buf.c 1.14 1.18 >> ffs/buf.h 1.8 >> >> Obtained from: NetBSD >> Sponsored by: The FreeBSD Foundation > > This commit broke building releases and a number of tests: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/3003/ . > Thanks, > -Ngie I reverted the `sectorsize` portion of this change in r317967 to unbreak the makefs and the fstyp tests. It seems that ffs_validate(..) isn’t called in all cases properly, or the structure isn’t being initialized properly. Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZELz8AAoJEPWDqSZpMIYVaJcP/0ld1ywAg6eep0NNGE7V4NLV kryVUzEJ9H0FHrAu88FL0P2kXeSohnNdUzQbDSv1djUr6MJA5QF6fYgaXyqh9s9z u09BEWdg6AyuKrCtM61EowrDu45m9p/sbNnnydt6ZQ18gCc5r8win3mI/boik6Cb Xyj12EHO8oNS1fIwLZOZlobbfAygivQ8HqDkT8FTrqxFdtHuyq3I+1bOdI/FnIG4 oBMHdwfrzb5PhHYQC8MYGza6ILoEF5+h0JUKdoYUcyraqsbBtiwoMkuQSJARofOp nK9SyMHj5nubc+lnofJLeNYDRKW5OAgoRa1iPbET7S14dNEBK/vEP9MhxYbqeBPd s/Lgt/4tW5dsE4OfOCYCHXCQdC5oYGz5VFg9d+rBUeJdk2kh8VdOjsDQN27zIwp9 2osVwZkRgTOytvCDqFHc1rHxKHE/+5yzxf1pu6Es++0lejNLZ5TeFz5gXGDe7Ilj /lneJFqxOGekoCN/GY3WaKys8E1SREA4qqJR8CP+bx7QSqoPxQFaN5x6e1WI/Y0R 1gXEtaSLA4UjrNHyCARPpzOU/GNGdt6qlUnmLVWIqN9w2NJPkb84BKWNWOOAw9vs CmtApFNKTmhKAXLZ4bk/9LwSju2t49FyuZnUOYcsxO/edMuNnagl40HMN1lzQGsm loaJVFbH726Pvo9U6Htr =RI4W -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?980BBC93-4004-4036-BEF4-3C58DB23BED6>