Date: Tue, 29 Jan 2019 08:55:19 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343543 - head/sbin/bectl/tests Message-ID: <5687EE07-74FB-4233-B51D-C8948641E8CB@gmail.com> In-Reply-To: <CACNAnaH5Qnfzenkwe1obM0DOfUZbvTjWg79o7FAobPrT6WYcaA@mail.gmail.com> References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <CACNAnaEmeQLwB%2Ba8KWyqB3GFWDn7on4gYtDrH7i5G6mj3zfSJw@mail.gmail.com> <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> <CACNAnaH5Qnfzenkwe1obM0DOfUZbvTjWg79o7FAobPrT6WYcaA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 29, 2019, at 08:39, Kyle Evans <kevans@freebsd.org> wrote: >=20 >> On Tue, Jan 29, 2019 at 10:32 AM Enji Cooper <yaneurabeya@gmail.com> wrot= e: >>=20 >>=20 >>>> On Jan 28, 2019, at 20:10, Kyle Evans <kevans@freebsd.org> wrote: >>>>=20 >>>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans <kevans@freebsd.org> wrote:= >>>>=20 >>>> Author: kevans >>>> Date: Tue Jan 29 04:08:49 2019 >>>> New Revision: 343543 >>>> URL: https://svnweb.freebsd.org/changeset/base/343543 >>>>=20 >>>> Log: >>>> bectl(8) test: Force destroy the zpool in cleanup >>>>=20 >>>> This is a wild guess as to why bectl tests failed once upon a time in C= I, >>>> given no apparent way to see a transcript of cleanup routines with Kyua= . The >>>> bectl tests construct a new, clean zpool for every test. The failure >>>> indicated was because of a mount that was leftover from a previous test= , but >>>> the previous test had succeeded so it's not clear how the mount remaine= d >>>> leftover unless the `zpool get health ${pool}` had somehow failed. >>>>=20 >>>=20 >>> I left out: the tests are supposed to be constructed to clean up any >>> mounts that were left over in the course of the test, hence the >>> assumption that the failure lies in the cleanup. >>=20 >> Hi Kyle, >>=20 >> The tests use a deterministic zpool name defined locally (not globally), a= nd will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succeed= s. >>=20 >> The tests will work the first time (when the zpool doesn=E2=80=99t exist)= , but I believe they=E2=80=99re actually introducing nondeterminism by accid= ent. I will propose a fix for this. >>=20 >> There=E2=80=99s a way to decipher why things failed from /var/log/message= s and kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t k= now what to look for. Can you please provide a failing ci run? >>=20 >=20 > Hi, >=20 > Thanks! Any help is appreciated -- my inquiry to -testing@ in response > to the weekly report where the failing test [1] was mentioned has been > met with silence. The failure is consistent in the i386-test job, but > amd64-test sees nothing of the sort (and neither does my local > testing). Thanks for the reminder to rejoin that list. > [1] https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/426/testReport/= sbin.bectl/bectl_test/bectl_mount/ It=E2=80=99s pretty obvious from the above run what=E2=80=99s going on from t= he output. A similarly named zpool (same prefix; suffixed with a 2) is being= matched by grep, even though the test sets up one with a suffix in the prec= eding steps. It=E2=80=99s probably and issue with timing and the bhyve implementation for= amd64 vs i386, or something else. Cheers, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5687EE07-74FB-4233-B51D-C8948641E8CB>