Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Oct 2014 16:52:49 +0000
From:      Andrew Turner <andrew@fubar.geek.nz>
To:        Andrew Turner <andrew@FreeBSD.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r273830 - stable/10/sys/arm/arm
Message-ID:  <20141029165249.046b8e8b@bender.lan>
In-Reply-To: <201410291641.s9TGfLe3030937@svn.freebsd.org>
References:  <201410291641.s9TGfLe3030937@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 29 Oct 2014 16:41:21 +0000 (UTC)
Andrew Turner <andrew@FreeBSD.org> wrote:
> Author: andrew
> Date: Wed Oct 29 16:41:20 2014
> New Revision: 273830
> URL: https://svnweb.freebsd.org/changeset/base/273830
> 
> Log:
>   MFC r273288:
>   
>    Allow the armv6 kernel to be build with PHYSADDR undefined. The
> kernel will now find the virtual to physical mapping for libkvm to
> use at runtime. This makes PHYSADDR redundant, however keep it around
> to give everyone a chance to update their libkvm.

...

> @@ -54,15 +66,21 @@ __FBSDID("$FreeBSD$");
>  	CPWAIT_BRANCH			/* branch to next insn
> */ 
>  /*
> - * This is for kvm_mkdb, and should be the address of the beginning
> + * This is for libkvm, and should be the address of the beginning
>   * of the kernel text segment (not necessarily the same as kernbase).
> + *
> + * These are being phased out. Newer copies of libkvm don't need
> these
> + * values as the information is added to the core file by inspecting
> + * the running kernel.
>   */
>  	.text
>  	.align	0
> +#ifdef PHYSADDR
>  .globl kernbase
>  .set kernbase,KERNBASE
>  .globl physaddr
>  .set physaddr,PHYSADDR
> +#endif

While this is now an option PHYSADDR should be enabled on all kernel
configs in this branch. It could be considered a POLA violation to have
an old libkvm not work with a new kernel dump. This change just allows
users to change their kernel config to not define PHYSADDR.

Abndrew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141029165249.046b8e8b>