Date: Tue, 2 Mar 2010 21:28:45 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204591 - in head: sbin/ipfw sys/conf sys/net sys/netinet sys/netinet/ipfw sys/netinet/ipfw/test Message-ID: <20100302192845.GD2489@deviant.kiev.zoral.com.ua> In-Reply-To: <20100302190344.GA5490@onelab2.iet.unipi.it> References: <201003021740.o22HemPA096942@svn.freebsd.org> <20100302185130.GC2489@deviant.kiev.zoral.com.ua> <20100302190344.GA5490@onelab2.iet.unipi.it>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Tue, Mar 02, 2010 at 08:03:44PM +0100, Luigi Rizzo wrote:
> On Tue, Mar 02, 2010 at 08:51:30PM +0200, Kostik Belousov wrote:
> ...
> > > --- head/sbin/ipfw/Makefile Tue Mar 2 17:34:11 2010 (r204590)
> > > +++ head/sbin/ipfw/Makefile Tue Mar 2 17:40:48 2010 (r204591)
> > > @@ -3,7 +3,6 @@
> > > PROG= ipfw
> > > SRCS= ipfw2.c dummynet.c ipv6.c main.c nat.c altq.c
> > > WARNS?= 2
> > > -DPADD= ${LIBUTIL}
> > > LDADD= -lutil
> > > MAN= ipfw.8
> > Removal of DPADD is most likely regression ?
>
> possibly.
> i couldn't figure out why it was there in the
> first place, can you clarify what it was for ?
To depend on the libutil, so that ipfw is reloaded when libutil.a is
changed.
The question I do not know answer for, is why do we need LDADD.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
iEYEARECAAYFAkuNZu0ACgkQC3+MBN1Mb4iwVwCgmQVXIqVCCkjI8ETIDAjIZ6os
wXAAn3WU9A5T/0F4LJ2pK0jZkFSPk9xn
=qBep
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100302192845.GD2489>