Date: Tue, 10 Jul 2018 08:52:15 +0100 From: Steven Hartland <steven.hartland@multiplay.co.uk> To: rgrimes@freebsd.org, "Jonathan T. Looney" <jtl@freebsd.org> Cc: Matt Macy <mmacy@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335856 - in head/sys: netinet sys Message-ID: <796f5a04-a4a5-372d-d2ed-4b36d6b04392@multiplay.co.uk> In-Reply-To: <201807021630.w62GUVEQ034521@pdx.rh.CN85.dnsmgr.net> References: <201807021630.w62GUVEQ034521@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry guys I didn't spot it was just a revert as it was tagged on to the end of the description, I would have expected that to be in the subject. What do others think, is there an recommend style for revert commit messages? Regards Steve On 02/07/2018 17:30, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < >> steven.hartland@multiplay.co.uk> wrote: >>> You have M_WAITOK and a null check in this change >> And, that's the same as the way it was before his commits. So, he did >> exactly what he said he was doing and reverted his commits. I don't think >> it is good practice to mix reverts with other changes. > It is a very bad practive to mix a revert with anything. > >> Since you've noticed this, I think you should feel free to make the change. >> Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?796f5a04-a4a5-372d-d2ed-4b36d6b04392>