Date: Tue, 18 Nov 2014 09:46:26 +0300 From: Chagin Dmitry <dchagin@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274635 - head/sys/dev/pci Message-ID: <20141118064626.GA956@dchagin.static.corbina.net> In-Reply-To: <2245618.H2SPKlpWdS@ralph.baldwin.cx> References: <201411172025.sAHKPLMl055666@svn.freebsd.org> <2245618.H2SPKlpWdS@ralph.baldwin.cx>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Nov 17, 2014 at 05:45:23PM -0500, John Baldwin wrote: > On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote: > > Author: dchagin > > Date: Mon Nov 17 20:25:21 2014 > > New Revision: 274635 > > URL: https://svnweb.freebsd.org/changeset/base/274635 > > > > Log: > > Use the correct device as the power_for_sleep() method > > always pass request up to parent bridge. > > > > Reviewed by: jhb > > MFC after: 1 week > > xMFC: r274386,r274397 > > Hmm, I had misread this diff as being another instance of what Adrian had > found. I think this is actually not correct. The parent of a pci device > ('dev' here) is a pciX device. pciX devices do not implement the > PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke > Adrian's Asus laptop as now it will always use D3 again and ignore _SxD. ugh.. i understood, let me see more closely > > You said that this change fixed your laptop, yes? Did it work before Adrian's > change in r274386 and break afterwards? yes -- Have fun! chd [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRq60IACgkQ0t2Tb3OO/O39JgCdHpPTc+4p2g2nm7LyggdTTNUv 8IAAoLP6nu/GLnfOBEFyenAJl293CZkz =xIpI -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141118064626.GA956>