Date: Thu, 22 Jul 2021 02:18:50 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 2929813c4f89 - main - Revert "awk: Issue a warning for old hex behavior." Message-ID: <202107220218.16M2IoXd086191@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=2929813c4f89388272a8bc034b09e72c5bf4e9c7 commit 2929813c4f89388272a8bc034b09e72c5bf4e9c7 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2021-07-22 02:17:50 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2021-07-22 02:17:50 +0000 Revert "awk: Issue a warning for old hex behavior." This reverts commit acf9cf323f8d0c844ea4a0fedeb596871794a078. It warns about too many false positive cases. Sponsored by: Netflix --- contrib/one-true-awk/lib.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/contrib/one-true-awk/lib.c b/contrib/one-true-awk/lib.c index c2da07a7ba62..6bfe5e8eaad9 100644 --- a/contrib/one-true-awk/lib.c +++ b/contrib/one-true-awk/lib.c @@ -798,16 +798,11 @@ bool is_valid_number(const char *s, bool trailing_stuff_ok, * where hex strings were treated as numbers in nawk the whole time it has been * in FreeBSD (since 2001). The POSIX 2001 through 2004 standards mandated this * behavior and the current standard allows it. Deviate from upstream by restoring - * the prior FreeBSD behavior, but warning that it differs. + * the prior FreeBSD behavior. */ +#if 0 // no hex floating point, sorry if (s[0] == '0' && tolower(s[1]) == 'x') -#ifdef __FreeBSD__ - { static int warned = 0; /* Only warn the first time */ - if (warned++ == 0) - WARNING("Script depends on old '0x' hex conversion behavior"); - } -#else return false; #endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107220218.16M2IoXd086191>