Date: Thu, 28 Mar 2019 09:41:49 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Oliver Pinter <oliver.pinter@hardenedbsd.org>, Ed Maste <emaste@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r345625 - in head: contrib/elftoolchain/readelf lib/libc lib/libthr libexec/rtld-elf sys/sys Message-ID: <3d5e5264-bd98-7c57-b849-45affa974e1b@FreeBSD.org> In-Reply-To: <CAPQ4ffv2JBs8Br%2B39sW2pNqxTTVLA3ROoFLFhABq3XDR-TcbQw@mail.gmail.com> References: <201903280212.x2S2CXoG000730@repo.freebsd.org> <CAPQ4ffv2JBs8Br%2B39sW2pNqxTTVLA3ROoFLFhABq3XDR-TcbQw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/28/19 4:25 AM, Oliver Pinter wrote: > On Thursday, March 28, 2019, Ed Maste <emaste@freebsd.org> wrote: > >> Author: emaste >> Date: Thu Mar 28 02:12:32 2019 >> New Revision: 345625 >> URL: https://svnweb.freebsd.org/changeset/base/345625 >> >> Log: >> revert r341429 "disable BIND_NOW in libc, libthr, and rtld" >> >> r345620 by kib@ fixed the rtld issue that caused a crash at startup >> during resolution of libc's ifuncs with BIND_NOW. >> >> PR: 233333 >> Sponsored by: The FreeBSD Foundation >> >> Modified: >> head/contrib/elftoolchain/readelf/readelf.c >> head/lib/libc/Makefile >> head/lib/libthr/Makefile >> head/libexec/rtld-elf/Makefile >> head/sys/sys/elf_common.h >> >> Modified: head/contrib/elftoolchain/readelf/readelf.c >> ============================================================ >> ================== >> --- head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 01:12:44 2019 >> (r345624) >> +++ head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 02:12:32 2019 >> (r345625) >> @@ -3490,6 +3490,7 @@ dump_notes(struct readelf *re) >> >> static struct flag_desc note_feature_ctl_flags[] = { >> { NT_FREEBSD_FCTL_ASLR_DISABLE, "ASLR_DISABLE" }, >> + { NT_FREEBSD_FCTL_IMPLIED_MAX_PROT, "IMPLIED_MAX_PROT" }, >> { 0, NULL } >> }; >> >> > Seems like this and the other hunk belongs to a different patch. Indeed. It broke the build for me -- Renato Botelho
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3d5e5264-bd98-7c57-b849-45affa974e1b>