Date: Tue, 25 Jan 2011 10:18:23 -0500 From: Andrew Duane <aduane@juniper.net> To: Jayachandran C. <c.jayachandran@gmail.com>, "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: RE: [PATCH] update sf_buf and uio for n64 Message-ID: <AC6674AB7BC78549BB231821ABF7A9AE91C1B58E19@EMBX01-WF.jnpr.net> In-Reply-To: <AANLkTik%2BpMOxCaD70oZJPsmKa4mNCviZmzLhxe8wQR-y@mail.gmail.com> References: <AANLkTik%2BpMOxCaD70oZJPsmKa4mNCviZmzLhxe8wQR-y@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
A minor comment/question, from someone just getting up to speed on the MIPS= ports here. Would it be slightly cleaner to use the sf_buf_page routine in sf_buf_kva, = rather than a duplicated cast? It would clarify the use a little. I am assu= ming the sf_buf_page is an inline routine rather than a #define to match th= e 32-bit API? -- Andrew Duane Juniper Networks 978-589-0551 10 Technology Park Dr aduane@juniper.net Westford, MA 01886-3418 ________________________________________ From: owner-freebsd-mips@freebsd.org [owner-freebsd-mips@freebsd.org] On Be= half Of Jayachandran C. [c.jayachandran@gmail.com] Sent: Tuesday, January 25, 2011 8:48 AM To: freebsd-mips@freebsd.org Subject: [PATCH] update sf_buf and uio for n64 This is one of the remaining pieces in n64 work from Juli's octeon branch. The attached patch updates the sf_buf code and uio_machdep.c in n64 compilation to use direct mapping. Planning to check this in later this week, if there are no objections. JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC6674AB7BC78549BB231821ABF7A9AE91C1B58E19>