Date: Tue, 18 Apr 2023 08:12:51 +0200 From: Gordon Bergling <gbe@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Message-ID: <ZD4044dQFqKchPYO@lion.ttyv0.de> In-Reply-To: <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Jess, On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: > On 18 Apr 2023, at 06:15, Gordon Bergling <gbe@FreeBSD.org> wrote: [...] > > --- a/stand/i386/boot0/Makefile > > +++ b/stand/i386/boot0/Makefile > > @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f > > # 0xb6 (182d) corresponds to 10 seconds. > > BOOT_BOOT0_TICKS?= 0xb6 > > > > -# The base address that we the boot0 code to to run it. Don't change this > > +# The base address that we the boot0 code to run it. Don't change this > > This was correct and is now incorrect; read as “that we [load] the > boot0 code to in order to run it”. > > Jess I just reverted the change. Sorry, not a native speaker on this side and the sentence was a little hard to understand. --Gordon > > # unless you are glutton for punishment. > > BOOT_BOOT0_ORG?= 0x600 > > ORG=${BOOT_BOOT0_ORG} > > diff --git a/stand/libsa/zfs/zfsimpl.c b/stand/libsa/zfs/zfsimpl.c > > index 76063e76225f..4a285470642e 100644 > > --- a/stand/libsa/zfs/zfsimpl.c > > +++ b/stand/libsa/zfs/zfsimpl.c > > @@ -447,7 +447,7 @@ vdev_indirect_mapping_entry(vdev_indirect_mapping_t *vim, uint64_t index) > > * > > * It's possible that the given offset will not be in the mapping table > > * (i.e. no mapping entries contain this offset), in which case, the > > - * return value value depends on the "next_if_missing" parameter. > > + * return value depends on the "next_if_missing" parameter. > > * > > * If the offset is not found in the table and "next_if_missing" is > > * B_FALSE, then NULL will always be returned. The behavior is intended
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZD4044dQFqKchPYO>