Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Oct 2012 11:17:27 +0200
From:      Fabien Thomas <fabien.thomas@netasq.com>
To:        hiren panchasara <hiren.panchasara@gmail.com>
Cc:        Davide Italiano <davide.italiano@gmail.com>, freebsd-current <freebsd-current@freebsd.org>, Jim Harris <jim.harris@gmail.com>
Subject:   Re: [CFT]hwpmc update for sandybridge-e
Message-ID:  <1894C6A5-2479-4D1B-9A68-1DC6818759F0@netasq.com>
In-Reply-To: <CALCpEUEsDSsbq=e6=GDao7D7LvN0K5WBO8WDh4UEV9XJNeUkBQ@mail.gmail.com>
References:  <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> <E62FEDB0-2DB8-408F-8D2B-3A40526035AB@netasq.com> <D67C86BC-B139-4472-9FE0-E09725D1CB55@netasq.com> <CALCpEUGNRzWgmaj2KDj8VkHMjw_6uGvcjSiWT-t%2B63iUUsh64g@mail.gmail.com> <D0A99DA2-8348-441F-ACD1-BAF79AC89D14@netasq.com> <CALCpEUGdQ3ex_zopmBY_Xmf1dsB_2crZXUhnuCmYpNVTmpHF_Q@mail.gmail.com> <CAJP=Hc9YdQC5jz3H8aEdsT7xtTTWTFGyiDou1LVwLD8ROxC7Lw@mail.gmail.com> <CALCpEUE_NcH9AsSuq5r1eQ-nPU5z3KOa2LKvJYRFvsGQ2hRajQ@mail.gmail.com> <CAJP=Hc_rLHkmagvHW0m3pq0kb-=ShTvG3sGhvJoh9pcVREcJDg@mail.gmail.com> <CALCpEUH=hwOtrnk-BS2qZv_6RfPYOf2rGfK3tkL%2B=LBxg_4FWw@mail.gmail.com> <CALCpEUEuDf0x0KxK6-M5TuMbHuEnxOay4_YFJH60dc%2BMdT=vRQ@mail.gmail.com> <CAJP=Hc_rR5p9023GWV--BMUnp%2BQ9F%2BkRJVxR01ztf-ZR4LL_Xg@mail.gmail.com> <CALCpEUEsDSsbq=e6=GDao7D7LvN0K5WBO8WDh4UEV9XJNeUkBQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

Le 18 oct. 2012 =E0 03:07, hiren panchasara a =E9crit :

> + Sean - who got dropped from the chain somehow.=20
>=20
> On Wed, Oct 17, 2012 at 6:01 PM, Jim Harris <jim.harris@gmail.com> =
wrote:
> On Wed, Oct 17, 2012 at 5:55 PM, hiren panchasara
> <hiren.panchasara@gmail.com> wrote:
> >
> >
> > On Wed, Oct 17, 2012 at 5:12 PM, hiren panchasara
> > <hiren.panchasara@gmail.com> wrote:
> >>
> >>
> >>
> >> On Wed, Oct 17, 2012 at 5:00 PM, Jim Harris <jim.harris@gmail.com> =
wrote:
> >>>
> >>> On Wed, Oct 17, 2012 at 3:57 PM, hiren panchasara
> >>> <hiren.panchasara@gmail.com> wrote:
> >>> >
> >>> <snip>
> >>> >
> >>> >
> >>> > Thanks for the pointers Jim!
> >>> >
> >>> > It seems that everything works now with:
> >>> >
> >>> > http://www.strugglingcoder.info/patches/hwpmc_sbx_3.txt
> >
> >
> > I've also made following change in existing sandybridge (not xeon =
:-) )
> > mappings.
> > Let me know if that looks reasonable.
> >
> >
> > @@ -2772,7 +2777,7 @@
> >  __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.XSNP_NONE",
> > IAP_EVENT_D2H_08H)    \
> >  __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.LLC_MISS",
> > IAP_EVENT_D4H_02H)    \
> >  __PMC_EV_ALIAS("L2_TRANS.DEMAND_DATA_RD", IAP_EVENT_F0H_01H)        =
         \
> > -__PMC_EV_ALIAS("L2_TRANS.RF0", IAP_EVENT_F0H_02H)                   =
         \
> > +__PMC_EV_ALIAS("L2_TRANS.RFO", IAP_EVENT_F0H_02H)                   =
         \
> >  __PMC_EV_ALIAS("L2_TRANS.CODE_RD", IAP_EVENT_F0H_04H)               =
                 \
> >  __PMC_EV_ALIAS("L2_TRANS.ALL_PF", IAP_EVENT_F0H_08H)                =
         \
> >  __PMC_EV_ALIAS("L2_TRANS.L1D_WB", IAP_EVENT_F0H_10H)                =
         \
>=20
> This is a reasonable change, but it should be part of a separate =
commit.
>=20
> Sure, I will separate it out.
>=20
> If there are no further comments, can I ask Sean to commit on my =
behalf?

Can you do the man page to include both in the commit?
Except that point seems good to me.
Thanks!

Fabien

>=20
> Thanks,
> Hiren=20




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1894C6A5-2479-4D1B-9A68-1DC6818759F0>