Date: Sun, 10 Dec 2000 22:40:11 -0800 (PST) From: yasu@mrit.mei.co.jp To: freebsd-gnats-submit@FreeBSD.org Subject: kern/23457: typeo in kern_sig.c Message-ID: <200012110640.eBB6eBZ26190@freefall.freebsd.org> Resent-Message-ID: <200012110650.eBB6o1Y27203@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 23457
>Category: kern
>Synopsis: typeo in kern_sig.c
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 10 22:50:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Yasuhiko Watanabe
>Release: 4.1-STABLE
>Organization:
Matsushita Research Institute Tokyo, Inc.
>Environment:
>Description:
kern_sig.c was fully rewritten due to new sigset_t types around Sep. 1999. (between rev 1.64 to 1.65) There seems suspicous typo in trapsignal().
- mask = sigmask(signum);
- if ((p->p_flag & P_TRACED) == 0 && (p->p_sigcatch & mask) != 0 &&
- (p->p_sigmask & mask) == 0) {
+ if ((p->p_flag & P_TRACED) == 0 && SIGISMEMBER(p->p_sigcatch, sig) &&
+ SIGISMEMBER(p->p_sigmask, sig)) {
p->p_stats->p_ru.ru_nsignals++;
I guess the last condition in if statement should be !SIGMEMBER(p->p_sigmask, sig) instead of SIGMEMBER(p->p_sigmask, sig)
>How-To-Repeat:
>Fix:
need a ! before the last SIGMEMBER()
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012110640.eBB6eBZ26190>