Date: Tue, 11 Nov 2014 07:34:04 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Andrey Chernov <ache@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r274365 - head/contrib/tzcode/stdtime Message-ID: <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com> In-Reply-To: <54621043.9000502@freebsd.org> References: <201411110407.sAB47gBT003976@svn.freebsd.org> <54621043.9000502@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 11, 2014, at 05:33, Andrey Chernov <ache@freebsd.org> wrote: >=20 >> On 11.11.2014 7:07, Garrett Cooper wrote: >> Author: ngie >> Date: Tue Nov 11 04:07:41 2014 >> New Revision: 274365 >> URL: https://svnweb.freebsd.org/changeset/base/274365 >>=20 >> Log: >> Revert WiP to contrib/tzcode accidentally committed with r274364 >=20 > This code is wrong in any case, setting EOVERFLOW even in unneeded > no-error cases like breaking from the loop. See how NetBSD does it > correctly instead. Hi! I saw your reply earlier but hadn't gotten an opportunity to revise the p= atch like you suggested. I'll look at the NetBSD code and see if I can adapt= it to our copy of tzcode. Thank you!=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E>