Date: Sat, 13 Jul 2024 16:30:31 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, "arrowd@FreeBSD.org" <arrowd@freebsd.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> In-Reply-To: <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Jul 13, 2024 at 02:04:48PM GMT, Daniel Engberg wrote: > On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@freebsd.org> > wrote: > > > On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote: > >> Hi, > >> > >> This changes so LTO option is no longer applied to Rust (cargo) > >> ports > >> > >> BY DEFAULT causing a regresssion, please fix. > > > > As it has been three months, nobody complained something was broken > > so, > > > > I don't think anything is actually broken. > > > > LTO as are a few other features like SSP are user facing features, > > not a > > > > porters facing options, it means, it's up to the person doing the > > > > building to choose wether to enable it or not, it is **not** up to > > the > > > > person porting the software to forcefully enable it. > > > > -- > > > > Mathieu Arnold > > Hi, > > Likely because this pretty much silently went by because it was posted > on Phab and you only CCed bapt. It's been enabled since Jan 2023 > (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b) > and tested/discussed here https://reviews.freebsd.org/D36736 before > being enabled/committed. I noticed it now while updating a Rust > (cargo-based) port. Mmmm, yes, I know about that, and I agree, this commits reverts this behavior. Because choosing to build with or without LTO is a user facing feature, not a porter facing feature, so, it has to be set by people building the things, not by the framework or a port. -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmaSj4VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6UiQwAopiCerCaC9PrO4JttiyfdI8koUIbkUnTQZ3L3EnqVI1wvDGXApVhxnV+ XvKgQNnEVtC7gPDRyxc1c7u9DnKA3pu+6fiv0DXD+8lM3psKag5fiXHbTKNrFg/S +QN+Wm6xpk78kUN/PDJyKAPizb/nN3vpqosBSREP7WR/q9LX8mDLiUvtnJmvK2e+ HRnXVnk2bkvt2Pwf6lzyYg1pvzjt5jeXA9RtQIuQ12F8lm11K+0xCqitSP1zpgXf 3uqCkZDQUplwAW3ftDow9qwpzmc/BeqOKDAwxjchWCTT31M6IroKKmIiTobf1BtN 0TJLqmzy+2rfb/d4gPpZm/Hi5AuTv1I/9s4S6h0WXzya2a7p7xeKcjKYhFIXV1PT 4hc/ntw/ZjElejFuRIZosXpWjFpF3MmSFHm1s3QG2MtFb115hK5Yf2rAq20vkX9z BcXaakm746U2B/oFO7MlmCBNS6OTkMg1cG850HquGqDaCos3oYhC01qWlQR+Y8hI 6qxaN3Mm =V2oJ -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k>