Date: Sat, 13 Jul 2024 16:30:31 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, "arrowd@FreeBSD.org" <arrowd@freebsd.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> In-Reply-To: <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--4egqw45pseg2fke7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 13, 2024 at 02:04:48PM GMT, Daniel Engberg wrote: > On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@freebsd.org> > wrote: >=20 > >=A0On=A0Sat,=A0Jul=A013,=A02024=A0at=A006:11:04AM=A0GMT,=A0Daniel=A0Engb= erg=A0wrote: > >>=A0=A0Hi, > >>=A0=A0 > >>=A0=A0=A0This=A0changes=A0so=A0LTO=A0option=A0is=A0no=A0longer=A0applie= d=A0to=A0Rust=A0(cargo) > >>=A0=A0ports > >>=A0=A0 > >>=A0=A0=A0BY=A0DEFAULT=A0causing=A0a=A0regresssion,=A0please=A0fix. > >=A0 > >=A0As=A0it=A0has=A0been=A0three=A0months,=A0nobody=A0complained=A0someth= ing=A0was=A0broken > >=A0so, > >=A0 > >=A0I=A0don't=A0think=A0anything=A0is=A0actually=A0broken. > >=A0 > >=A0LTO=A0as=A0are=A0a=A0few=A0other=A0features=A0like=A0SSP=A0are=A0user= =A0facing=A0features, > >=A0not=A0a > >=A0 > >=A0porters=A0facing=A0options,=A0it=A0means,=A0it's=A0up=A0to=A0the=A0pe= rson=A0doing=A0the > >=A0 > >=A0building=A0to=A0choose=A0wether=A0to=A0enable=A0it=A0or=A0not,=A0it= =A0is=A0**not**=A0up=A0to > >=A0the > >=A0 > >=A0person=A0porting=A0the=A0software=A0to=A0forcefully=A0enable=A0it. > >=A0 > >=A0--=A0 > >=A0 > >=A0Mathieu=A0Arnold >=20 > Hi, >=20 > Likely because this pretty much silently went by because it was posted > on Phab and you only CCed bapt. It's been enabled since Jan 2023 > (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=3D967022fd812c= f67dec264ee4e53bd016b69e7a2b) > and tested/discussed here https://reviews.freebsd.org/D36736 before > being enabled/committed. I noticed it now while updating a Rust > (cargo-based) port. Mmmm, yes, I know about that, and I agree, this commits reverts this behavior. Because choosing to build with or without LTO is a user facing feature, not a porter facing feature, so, it has to be set by people building the things, not by the framework or a port. --=20 Mathieu Arnold --4egqw45pseg2fke7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmaSj4VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6UiQwAopiCerCaC9PrO4JttiyfdI8koUIbkUnTQZ3L3EnqVI1wvDGXApVhxnV+ XvKgQNnEVtC7gPDRyxc1c7u9DnKA3pu+6fiv0DXD+8lM3psKag5fiXHbTKNrFg/S +QN+Wm6xpk78kUN/PDJyKAPizb/nN3vpqosBSREP7WR/q9LX8mDLiUvtnJmvK2e+ HRnXVnk2bkvt2Pwf6lzyYg1pvzjt5jeXA9RtQIuQ12F8lm11K+0xCqitSP1zpgXf 3uqCkZDQUplwAW3ftDow9qwpzmc/BeqOKDAwxjchWCTT31M6IroKKmIiTobf1BtN 0TJLqmzy+2rfb/d4gPpZm/Hi5AuTv1I/9s4S6h0WXzya2a7p7xeKcjKYhFIXV1PT 4hc/ntw/ZjElejFuRIZosXpWjFpF3MmSFHm1s3QG2MtFb115hK5Yf2rAq20vkX9z BcXaakm746U2B/oFO7MlmCBNS6OTkMg1cG850HquGqDaCos3oYhC01qWlQR+Y8hI 6qxaN3Mm =V2oJ -----END PGP SIGNATURE----- --4egqw45pseg2fke7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k>