Date: Tue, 27 Nov 2001 22:20:54 EET From: Maxim Sobolev <sobomax@FreeBSD.org> To: silby@silby.com, des@ofug.org Cc: brian@freebsd-services.com, rwatson@FreeBSD.org, gshapiro@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc security Message-ID: <200111272021.WAA02046@ipcard.iptcom.net> In-Reply-To: <20011127115346.R39566-100000@achilles.silby.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Nov 2001 11:55:53 -0600 (CST), Mike Silbersack wrote:
> =
> On 27 Nov 2001, Dag-Erling Smorgrav wrote:
> =
> > Mike Silbersack <silby@silby.com> writes:
> > > +=09=09=09 mail -s '$host security check output' $daily_status_sec=
urity_output;;
> >
> > Variables aren't expanded inside single-quoted strings. Use double
> > quotes.
> >
> > DES
> > --
> > Dag-Erling Smorgrav - des@ofug.org
> =
> Yep, that does the trick. At this rate, I may eventually learn shell
> scripting. :)
> =
> Here's the revised patch, I'll go ahead and commit it in a few hours
> unless there are further problems found.
> =
> Mike "Silby" Silbersack
> =
> --- /usr/src/etc/security=09Tue Nov 27 11:08:21 2001
> +++ /etc/security=09Tue Nov 27 11:13:35 2001
> @@ -58,8 +58,6 @@
> yesterday=3D`date -v-1d "+%b %e "`
> =
> host=3D`hostname`
> -[ $sflag =3D FALSE ] && echo "To: root@${host}"
> -[ $sflag =3D FALSE ] && echo "Subject: ${host} security check output"
> =
> umask 027
> =
> --- /usr/src/etc/periodic/daily/450.status-security=09Wed Jun 6 14:24:44=
2001
> +++ /etc/periodic/daily/450.status-security=09Tue Nov 27 11:55:00 2001
> @@ -36,8 +36,10 @@
> =09=09=09 >$daily_status_security_output 2>&1;;
> =09=09 *)
> =09=09=09echo " (output mailed separately)"
> +=09=09=09host=3D`hostname`
> +=09=09=09export host
What purpose this "export" serves?
> =09=09=09sh /etc/security $args 2>&1 |
> -=09=09=09 sendmail $daily_status_security_output;;
> +=09=09=09 mail -s "$host security check output" $daily_status_securit=
y_output;;
Why not:
+=09mail -s "`hostname` security check output"
?
-Maxim
> =09=09esac;;
> =09esac;;
> =
> =
> =
> =
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111272021.WAA02046>