Date: Thu, 06 Jan 2011 01:02:43 -0800 From: Julian Elischer <julian@freebsd.org> To: Edward Tomasz Napierala <trasz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217048 - head/share/man/man9 Message-ID: <4D258533.3@freebsd.org> In-Reply-To: <201101060833.p068Xmrj008299@svn.freebsd.org> References: <201101060833.p068Xmrj008299@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Thu Jan 6 08:33:48 2011 > New Revision: 217048 > URL: http://svn.freebsd.org/changeset/base/217048 > > Log: > Get rid of bad advice regarding /* NOTREACHED */. Compilers don't > really need it (one can use __dead2 instead), and style(9) was not > even consistent with itself in this regard. > > Modified: > head/share/man/man9/style.9 > > Modified: head/share/man/man9/style.9 > ============================================================================== > --- head/share/man/man9/style.9 Thu Jan 6 08:13:30 2011 (r217047) > +++ head/share/man/man9/style.9 Thu Jan 6 08:33:48 2011 (r217048) > @@ -470,9 +470,6 @@ statement that cascade should have a > .Li FALLTHROUGH > comment. > Numerical arguments should be checked for accuracy. > -Code that cannot be reached should have a > -.Li NOTREACHED > -comment. I object STRONGLY to this change. The NOTREACHED is also to help the reader understand what has happened and as an afterthought was also useful in LINT. I know know of no technological change to the average reader that makes it less useful. > .Bd -literal > while ((ch = getopt(argc, argv, "abNn:")) != -1) > switch (ch) { /* Indent the switch. */ > @@ -496,7 +493,6 @@ comment. > case '?': > default: > usage(); > - /* NOTREACHED */ > } > argc -= optind; > argv += optind; >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D258533.3>