Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 May 1998 02:03:13 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        bde@zeta.org.au, peter@netplex.com.au
Cc:        current@FreeBSD.ORG, dyson@FreeBSD.ORG, kkennawa@physics.adelaide.edu.au
Subject:   Re: libc corruption
Message-ID:  <199805161603.CAA30466@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>Yikes, I was not paying enough attention when syscall.mk came in.  I 
>wasn't aware of it's purpose.  IMHO, it should be in lib/libc/sys or lib/
>libc/i386/ somewhere.
>
>>  Since this is not automatic,
>> errors are often made the binary interface is not affected consistently
>> like it should be.
>
>I would argue that a change to the binary interface should be a deliberate
>thing, not something that's a side effect of a kernel change.  I'd be
>happier if syscall.mk was generated by something under the libc build area
>when the committer chooses to build it from syscalls.master and otherwise
>seperate to the kernel.

I can't think of any cases where it would be correct to commit changes to
add or remove a syscall from the kernel without updating the library.  For
development of changes you^H^H^HI normally want the changes to be propagated
automatically.

>> - checking out generated files sometimes breaks dependencies by clobbering
>>   timestamps.
>
>CVS tries to be smarter in that it checks out files with their commit 
>timestamps if there are no local modifications.  I could imagine that this 
>might be problematic if all the *syscall* files were wronly committed in 
>one go, but the extent of the damage is limited to what happens if 
>somebody tries to do a make of init_sysent.c or something in src/sys/kern, 
>something that nobody would normally do unless syscalls.master was changed.

It can't do that for updates since it would break at least Makefile
dependencies on changed files.  Small updates tend to give all the
updated files the same (current) time.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805161603.CAA30466>