Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Mar 2019 07:01:34 -0700
From:      Enji Cooper <yaneurabeya@gmail.com>
To:        Kyle Evans <kevans@freebsd.org>
Cc:        Enji Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r344067 - head/sbin/bectl/tests
Message-ID:  <51982BE3-DFA3-4150-AC02-F217AA66B567@gmail.com>
In-Reply-To: <CACNAnaGyieF1ARsGbN4FM_k=PiiryYd35Bsv8fRH8Xq%2Be0NU7w@mail.gmail.com>
References:  <201902122335.x1CNZlff065320@repo.freebsd.org> <CACNAnaGyieF1ARsGbN4FM_k=PiiryYd35Bsv8fRH8Xq%2Be0NU7w@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail


> On Mar 26, 2019, at 06:12, Kyle Evans <kevans@freebsd.org> wrote:
> 
>> On Tue, Feb 12, 2019 at 5:36 PM Enji Cooper <ngie@freebsd.org> wrote:
>> 
>> Author: ngie
>> Date: Tue Feb 12 23:35:46 2019
>> New Revision: 344067
>> URL: https://svnweb.freebsd.org/changeset/base/344067
>> 
>> Log:
>>  Fix up concurrent test zpool setup and teardown
>> 
>>  Set up zpools with a more unique name, stash the zpool name away in a file pointed
>>  to by `$ZPOOL_NAME_FILE` (which is relative to a per-testcase generated temporary
>>  directory), then remove the file based on `$ZPOOL_NAME_FILE` in the cleanup
>>  routines.
>> 
>>  This is a more concurrency-safe solution and will allow the testcases to be safely
>>  executed in parallel.
>> 
>>  Reviewed by:  kevans, jtl
>>  Approved by:  jtl (mentor)
>>  MFC after:    1 week
>>  Differential Revision: https://reviews.freebsd.org/D19024
>> 
> 
> Hi,
> 
> Any objections if I MFC this with some other bectl(8)/libbe(3) MFCs
> that I'll be doing soon?

Hi Kyle,
    Please go ahead. I was waiting for mentor approval of https://reviews.freebsd.org/D19546 over the past few weeks and haven’t received it. I didn’t press hard enough :/.
Thank you for being patient!
-Enji

help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51982BE3-DFA3-4150-AC02-F217AA66B567>