Date: Mon, 15 Jan 2007 19:33:30 +0100 From: Max Laier <max@love2party.net> To: Randall Stewart <rrs@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_subr.c src/sys/sys systm.h src/share/man/man9 Makefile hashinit.9 Message-ID: <200701151933.39686.max@love2party.net> In-Reply-To: <200701151506.l0FF6S6D022659@repoman.freebsd.org> References: <200701151506.l0FF6S6D022659@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2103125.ctJ6YU2YAR Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 15 January 2007 16:06, Randall Stewart wrote: > rrs 2007-01-15 15:06:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_subr.c > sys/sys systm.h > share/man/man9 Makefile hashinit.9 > Log: > Reviewed by: rwatson > Approved by: gnn > > Add a new function hashinit_flags() which allows NOT-waiting > for memory (or waiting). The old hashinit() function now > calls hashinit_flags(..., HASH_WAITOK); This breaks the tinderbox: > /src/sys/kern/kern_subr.c: In function `hashinit_flags': > /src/sys/kern/kern_subr.c:375: warning: suggest parentheses around > comparison in operand of | *** Error code 1 and why are we useing new flags, btw? Can't we just pass down the normal=20 malloc flags? I seem to remember that we do that in a couple of places=20 already. > Revision Changes Path > 1.288 +2 -1 src/share/man/man9/Makefile > 1.3 +26 -2 src/share/man/man9/hashinit.9 > 1.100 +36 -6 src/sys/kern/kern_subr.c > 1.248 +6 -1 src/sys/sys/systm.h =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2103125.ctJ6YU2YAR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBFq8kDXyyEoT62BG0RAnyyAKCBqTPO5tZKp7s81hl8wc5NIED/PgCeLbWZ 16vui29Cl7/viWYre3bLyu8= =qsGl -----END PGP SIGNATURE----- --nextPart2103125.ctJ6YU2YAR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701151933.39686.max>