Date: Sat, 20 Jan 2024 23:15:42 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Mikhail Teterin <mi@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple Message-ID: <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com> In-Reply-To: <202401202030.40KKUApC045320@gitrepo.freebsd.org> References: <202401202030.40KKUApC045320@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1705788942_509e858d642a423d08522cc13518fa7f_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-20T21:30:10.000+01:00, Mikhail Teterin <mi@FreeBSD.org> wrote:= >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0mi: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org/por= ts/commit/?id=3Db430a140c818789ed59ac538a708df67be42fc2a >=C2=A0 >= =C2=A0commit=C2=A0b430a140c818789ed59ac538a708df67be42fc2a >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mikhail=C2=A0Teterin=C2=A0<mi@Fr= eeBSD.org> >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-01-20=C2=A020:29:50= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mikhail= =C2=A0Teterin=C2=A0<mi@FreeBSD.org> >=C2=A0 >=C2=A0CommitDate:=C2=A0202= 4-01-20=C2=A020:29:50=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0net-im/purple-gowhatsapp:=C2=A0add=C2=A0WhatsApp=C2=A0plugin=C2=A0for= =C2=A0libpurple >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0The=C2=A0bulk=C2=A0of=C2=A0the=C2=A0code= =C2=A0is=C2=A0implemented=C2=A0in=C2=A0Go,=C2=A0and=C2=A0so=C2=A0some=C2= =A0challenges=C2=A0remain. >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Help= =C2=A0would=C2=A0be=C2=A0most=C2=A0welcome. >=C2=A0 >=C2=A0--- >= =C2=A0 >=C2=A0=C2=A0net-im/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0|=C2=A0=C2=A01=C2=A0+ >=C2=A0 >=C2=A0=C2=A0net-im/purple= -gowhatsapp/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A049=C2=A0++++++++++++++++++++++++++= >=C2=A0 >=C2=A0=C2=A0net-im/purple-gowhatsapp/distinfo=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|= =C2=A0=C2=A03=C2=A0++ >=C2=A0 >=C2=A0=C2=A0net-im/purple-gowhatsapp/fil= es/patch-configure=C2=A0|=C2=A027=C2=A0++++++++++++++ >=C2=A0 >=C2= =A0=C2=A0net-im/purple-gowhatsapp/pkg-descr=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A05=C2=A0+++= >=C2=A0 >=C2=A0=C2=A0net-im/purple-gowhatsapp/pkg-plist=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2= =A0=C2=A05=C2=A0+++ >=C2=A0 >=C2=A0=C2=A06=C2=A0files=C2=A0changed,= =C2=A090=C2=A0insertions(+) >=C2=A0 >=C2=A0diff=C2=A0--git=C2=A0a/net-i= m/Makefile=C2=A0b/net-im/Makefile >=C2=A0 >=C2=A0index=C2=A0e55c9365ebf= 8..63ce6b19620c=C2=A0100644 >=C2=A0 >=C2=A0---=C2=A0a/net-im/Makefile= >=C2=A0 >=C2=A0+++=C2=A0b/net-im/Makefile >=C2=A0 >=C2=A0@@=C2= =A0-104,6=C2=A0+104,7=C2=A0@@ >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0purple-discord >=C2=A0 >=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0purple-facebook >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0purple-googlechat= >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0purple-g= owhatsapp >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D= =C2=A0purple-mattermost >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0SUBDIR=C2=A0+=3D=C2=A0purple-plugin-pack >=C2=A0 >=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0purple-rocketchat >=C2=A0 >= =C2=A0diff=C2=A0--git=C2=A0a/net-im/purple-gowhatsapp/Makefile=C2=A0b/net-i= m/purple-gowhatsapp/Makefile >=C2=A0 >=C2=A0new=C2=A0file=C2=A0mode= =C2=A0100644 >=C2=A0 >=C2=A0index=C2=A0000000000000..c04ecd199d16 >= =C2=A0 >=C2=A0---=C2=A0/dev/null >=C2=A0 >=C2=A0+++=C2=A0b/net-im/pur= ple-gowhatsapp/Makefile >=C2=A0 >=C2=A0@@=C2=A0-0,0=C2=A0+1,49=C2=A0@@= >=C2=A0 >=C2=A0+PORTNAME=3D=C2=A0=C2=A0=C2=A0=C2=A0purple-gowhatsapp= >=C2=A0 >=C2=A0+DISTVERSIONPREFIX=3Dv >=C2=A0 >=C2=A0+DISTVERSION= =3D=C2=A0=C2=A0=C2=A0=C2=A01.13.0 >=C2=A0 >=C2=A0+CATEGORIES=3D=C2= =A0=C2=A0=C2=A0=C2=A0net-im >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+MAINTA= INER=3D=C2=A0=C2=A0=C2=A0=C2=A0mi@aldan.algebra.com >=C2=A0 >=C2=A0+COM= MENT=3D=C2=A0=C2=A0=C2=A0=C2=A0WhatsApp=C2=A0plugin=C2=A0for=C2=A0libpurple= >=C2=A0 >=C2=A0+WWW=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0https://github.com/hoehermann/purple-gowhatsapp >=C2=A0 >=C2=A0+ >= =C2=A0 >=C2=A0+LICENSE=3D=C2=A0=C2=A0=C2=A0=C2=A0GPLv3 >=C2=A0 >= =C2=A0+LICENSE_FILE=3D=C2=A0=C2=A0=C2=A0=C2=A0${WRKSRC}/LICENSE >=C2= =A0 >=C2=A0+ >=C2=A0 >=C2=A0+LIB_DEPENDS=3D=C2=A0=C2=A0=C2=A0=C2= =A0libpurple.so:net-im/libpurple=C2=A0[http://libpurple.so:net-im/libpurple= ]=C2=A0=C2=A0=C2=A0=C2=A0\ >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0libopusfile.so:audio/opusfile=C2=A0[http://libopusf= ile.so:audio/opusfile] >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+USES=3D= =C2=A0=C2=A0=C2=A0=C2=A0go:no_targets=C2=A0cmake=C2=A0dos2unix >=C2=A0 = >=C2=A0+ >=C2=A0 >=C2=A0+OPTIONS_MULTI=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0DB-backend >=C2=A0 >=C2= =A0+OPTIONS_MULTI_DB-backend=3D=C2=A0=C2=A0=C2=A0=C2=A0SQLITE3=C2=A0POSTGRE= S=C2=A0MYSQL >=C2=A0 >=C2=A0+OPTIONS_DEFAULT=3DSQLITE3 >=C2=A0 >= =C2=A0+.for=C2=A0o=C2=A0in=C2=A0${OPTIONS_MULTI_DB} >=C2=A0 >=C2=A0+$o_= DESC=3D=C2=A0=C2=A0=C2=A0=C2=A0Support=C2=A0use=C2=A0of=C2=A0$o=C2=A0for= =C2=A0storing=C2=A0account=C2=A0information >=C2=A0 >=C2=A0+.endfor >= =C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+USE_GITHUB=3D=C2=A0=C2=A0=C2=A0=C2= =A0yep... >=C2=A0 >=C2=A0+GH_ACCOUNT=3D=C2=A0=C2=A0=C2=A0=C2=A0hoeherma= nn >=C2=A0 >=C2=A0+DOS2UNIX_GLOB=3D=C2=A0=C2=A0=C2=A0=C2=A0CMake*.txt= >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+CMAKE_ARGS=3D=C2=A0=C2=A0=C2= =A0=C2=A0-DPURPLE_INCLUDE_DIRS=3D${LOCALBASE}/include/libpurple=C2=A0=C2= =A0=C2=A0=C2=A0\ >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0-DPURPLE_LIBRARY_DIRS=3D${LOCALBASE}/lib=C2=A0=C2=A0=C2= =A0=C2=A0\ >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0-DPURPLE_PLUGIN_DIR=3D${PREFIX}/lib/purple-2=C2=A0\ >=C2=A0 >= =C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-DPURPLE_DATA_DIR=3D= ${PREFIX}/share >=C2=A0 >=C2=A0+LDFLAGS+=3D=C2=A0=C2=A0=C2=A0=C2=A0-L${= LOCALBASE}/lib >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+post-patch-POSTGRES= -off: >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0${REINPLACE_CMD}=C2=A0'/l= ib\/pq/d'=C2=A0${WRKSRC}/src/go/login.go >=C2=A0 >=C2=A0+ >=C2=A0 >= =C2=A0+post-patch-MYSQL-off: >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2= =A0${REINPLACE_CMD}=C2=A0'/go-sql-driver\/mysql/d'=C2=A0${WRKSRC}/src/go/lo= gin.go >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+post-patch-SQLIT3-off: >= =C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0${REINPLACE_CMD}=C2=A0'/mattn\/go-= sqlite3/d'=C2=A0${WRKSRC}/src/go/login.go >=C2=A0 >=C2=A0+ >=C2=A0 = >=C2=A0+#=C2=A0The=C2=A0downloaded=C2=A0Go-files=C2=A0are=C2=A0read-only= =C2=A0and=C2=A0the=C2=A0simple=C2=A0rm=C2=A0-f=C2=A0does=C2=A0not=C2=A0work= >=C2=A0 >=C2=A0+#=C2=A0against=C2=A0them=C2=A0(unless=C2=A0invoked= =C2=A0as=C2=A0root).=C2=A0Here=C2=A0we=C2=A0relax=C2=A0the=C2=A0permissions= =C2=A0first: >=C2=A0 >=C2=A0+pre-clean: >=C2=A0 >=C2=A0+=C2=A0= =C2=A0=C2=A0=C2=A0-@${FIND}=C2=A0${WRKDIR}=C2=A0|=C2=A0${XARGS}=C2=A0${CHMO= D}=C2=A0u+w >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+.include=C2=A0<bsd.por= t.mk>=C2=A0[http://bsd.port.mk>]; >=C2=A0 >=C2=A0diff=C2=A0--git=C2= =A0a/net-im/purple-gowhatsapp/distinfo=C2=A0b/net-im/purple-gowhatsapp/dist= info >=C2=A0 >=C2=A0new=C2=A0file=C2=A0mode=C2=A0100644 >=C2=A0 >= =C2=A0index=C2=A0000000000000..440dd580ed44 >=C2=A0 >=C2=A0---=C2=A0/de= v/null >=C2=A0 >=C2=A0+++=C2=A0b/net-im/purple-gowhatsapp/distinfo >= =C2=A0 >=C2=A0@@=C2=A0-0,0=C2=A0+1,3=C2=A0@@ >=C2=A0 >=C2=A0+TIMESTAM= P=C2=A0=3D=C2=A01705716803 >=C2=A0 >=C2=A0+SHA256=C2=A0(hoehermann-purp= le-gowhatsapp-v1.13.0_GH0.tar.gz)=C2=A0=3D=C2=A0153229acd476ff1f98497074402= 944869c73e85ad06d6cfa8529bf4861960c96 >=C2=A0 >=C2=A0+SIZE=C2=A0(hoeher= mann-purple-gowhatsapp-v1.13.0_GH0.tar.gz)=C2=A0=3D=C2=A0140285 >=C2= =A0 >=C2=A0diff=C2=A0--git=C2=A0a/net-im/purple-gowhatsapp/files/patch-co= nfigure=C2=A0b/net-im/purple-gowhatsapp/files/patch-configure >=C2=A0 >= =C2=A0new=C2=A0file=C2=A0mode=C2=A0100644 >=C2=A0 >=C2=A0index=C2=A0000= 000000000..b8775407932d >=C2=A0 >=C2=A0---=C2=A0/dev/null >=C2=A0 >= =C2=A0+++=C2=A0b/net-im/purple-gowhatsapp/files/patch-configure >=C2= =A0 >=C2=A0@@=C2=A0-0,0=C2=A0+1,27=C2=A0@@ >=C2=A0 >=C2=A0+---=C2= =A0CMakeLists.txt=C2=A0=C2=A0=C2=A0=C2=A02023-09-01=C2=A016:15:26.000000000= =C2=A0-0400 >=C2=A0 >=C2=A0++++=C2=A0CMakeLists.txt=C2=A0=C2=A0=C2= =A0=C2=A02024-01-19=C2=A021:50:01.130852000=C2=A0-0500 >=C2=A0 >=C2= =A0+@@=C2=A0-4,3=C2=A0+4,2=C2=A0@@ >=C2=A0 >=C2=A0+=C2=A0 >=C2=A0 >= =C2=A0+=C2=A0set(Purple_DIR=C2=A0"${CMAKE_CURRENT_SOURCE_DIR}/submodules/pu= rple-cmake"=C2=A0CACHE=C2=A0PATH=C2=A0"Where=C2=A0to=C2=A0find=C2=A0purple-= config.cmake") >=C2=A0 >=C2=A0+-find_package(Purple=C2=A0REQUIRED) >= =C2=A0 >=C2=A0+@@=C2=A0-41,4=C2=A0+40,2=C2=A0@@ >=C2=A0 >=C2=A0+= =C2=A0 >=C2=A0 >=C2=A0+=C2=A0install(DIRECTORY=C2=A0"pixmaps"=C2=A0DEST= INATION=C2=A0"${PURPLE_DATA_DIR}"=C2=A0FILES_MATCHING=C2=A0PATTERN=C2=A0"*.= png") >=C2=A0 >=C2=A0+- >=C2=A0 >=C2=A0+-include(cpack.cmake) >= =C2=A0 >=C2=A0+---=C2=A0src/go/go.mod.in=C2=A0[http://go.mod.in]=C2=A0= =C2=A0=C2=A0=C2=A02023-09-01=C2=A016:15:26.000000000=C2=A0-0400 >=C2= =A0 >=C2=A0++++=C2=A0src/go/go.mod.in=C2=A0[http://go.mod.in]=C2=A0=C2= =A0=C2=A0=C2=A02024-01-19=C2=A023:14:27.315646000=C2=A0-0500 >=C2=A0 >= =C2=A0+@@=C2=A0-2,13=C2=A0+2,2=C2=A0@@ >=C2=A0 >=C2=A0+=C2=A0 >=C2= =A0 >=C2=A0+=C2=A0go=C2=A01.18 >=C2=A0 >=C2=A0+- >=C2=A0 >=C2= =A0+-require=C2=A0( >=C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2=A0github.com= /alfg/mp4=C2=A0[http://github.com/alfg/mp4]=C2=A0v0.0.0-20210728035756-55ea= 58c08aeb >=C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2=A0github.com/go-sql-dri= ver/mysql=C2=A0[http://github.com/go-sql-driver/mysql]=C2=A0v1.6.0 >= =C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2=A0github.com/lib/pq=C2=A0[http://gi= thub.com/lib/pq]=C2=A0v1.10.4 >=C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2= =A0github.com/mattn/go-sqlite3=C2=A0[http://github.com/mattn/go-sqlite3]= =C2=A0v1.14.10 >=C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2=A0github.com/mdp/= qrterminal/v3=C2=A0[http://github.com/mdp/qrterminal/v3]=C2=A0v3.0.0 >= =C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2=A0github.com/skip2/go-qrcode=C2= =A0[http://github.com/skip2/go-qrcode]=C2=A0v0.0.0-20200617195104-da1b65686= 86e >=C2=A0 >=C2=A0+-=C2=A0=C2=A0=C2=A0=C2=A0golang.org/x/net=C2=A0[htt= p://golang.org/x/net]=C2=A0v0.5.0=C2=A0 >=C2=A0 >=C2=A0+-=C2=A0=C2= =A0=C2=A0=C2=A0go.mau.fi/whatsmeow=C2=A0[http://go.mau.fi/whatsmeow]=C2= =A0latest >=C2=A0 >=C2=A0+-) >=C2=A0 >=C2=A0diff=C2=A0--git=C2= =A0a/net-im/purple-gowhatsapp/pkg-descr=C2=A0b/net-im/purple-gowhatsapp/pkg= -descr >=C2=A0 >=C2=A0new=C2=A0file=C2=A0mode=C2=A0100644 >=C2=A0 >= =C2=A0index=C2=A0000000000000..89e601b1a08d >=C2=A0 >=C2=A0---=C2=A0/de= v/null >=C2=A0 >=C2=A0+++=C2=A0b/net-im/purple-gowhatsapp/pkg-descr >= =C2=A0 >=C2=A0@@=C2=A0-0,0=C2=A0+1,5=C2=A0@@ >=C2=A0 >=C2=A0+A=C2= =A0libpurple/Pidgin=C2=A0plugin=C2=A0for=C2=A0WhatsApp. >=C2=A0 >=C2= =A0+ >=C2=A0 >=C2=A0+This=C2=A0is=C2=A0a=C2=A0re-write=C2=A0of=C2=A0pur= ple-gowhatsapp,=C2=A0switching=C2=A0back-ends=C2=A0from >=C2=A0 >=C2= =A0+go-whatsapp=C2=A0to=C2=A0whatsmeow.=C2=A0whatsmeow=C2=A0is=C2=A0written= =C2=A0by=C2=A0Tulir=C2=A0Asokan.=C2=A0It >=C2=A0 >=C2=A0+has=C2=A0multi= -device=C2=A0support. >=C2=A0 >=C2=A0diff=C2=A0--git=C2=A0a/net-im/purp= le-gowhatsapp/pkg-plist=C2=A0b/net-im/purple-gowhatsapp/pkg-plist >=C2= =A0 >=C2=A0new=C2=A0file=C2=A0mode=C2=A0100644 >=C2=A0 >=C2=A0index= =C2=A0000000000000..b4b08ff3d299 >=C2=A0 >=C2=A0---=C2=A0/dev/null >= =C2=A0 >=C2=A0+++=C2=A0b/net-im/purple-gowhatsapp/pkg-plist >=C2=A0 >= =C2=A0@@=C2=A0-0,0=C2=A0+1,5=C2=A0@@ >=C2=A0 >=C2=A0+lib/purple-2/libwh= atsmeow.so=C2=A0[http://libwhatsmeow.so] >=C2=A0 >=C2=A0+share/pixmaps/= pidgin/protocols/16/whatsapp.png >=C2=A0 >=C2=A0+share/pixmaps/pidgin/p= rotocols/22/whatsapp.png >=C2=A0 >=C2=A0+share/pixmaps/pidgin/protocols= /48/whatsapp.png >=C2=A0 >=C2=A0+share/pixmaps/pidgin/protocols/64/what= sapp.png Hi, Please at least enable DEVELOPER=3Dyes and fix any w= arnings Use the standard definition for POSTGRES, PGSQL https://c= git.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410 SQLITE option i= s broken "post-patch-SQLIT3-off" Overall ordering in Makefile can= be improved, LDFLAGS can probably be replaced with USES=3D localbase:ldf= lags Configure logs suggests that USES=3D pkgconfig should be added = It also fails to build https://pdr2.bofh.network/data/140-diizzy/20= 24-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log If you're = unsure please consider to create a review / PR instead of just committing= . Please back this out for now. Best regards, Daniel --_=_swift_1705788942_509e858d642a423d08522cc13518fa7f_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <div>On 2024-01-20T21:30:10.000+01:00, Mikhail Teterin <mi@FreeBSD.org&g= t; wrote:<br></div><div class=3D"ik_mail_quote answerContentMessage"><block= quote class=3D"ws-ng-quote"><pre style=3D"white-space: normal;"><div>The br= anch main has been updated by mi:<br></div><div><br></div><div>URL: <a href= =3D"https://cgit.FreeBSD.org/ports/commit/?id=3Db430a140c818789ed59ac538a70= 8df67be42fc2a" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener = noreferrer" data-ik=3D"ik-secure">https://cgit.FreeBSD.org/ports/commit/?id= =3Db430a140c818789ed59ac538a708df67be42fc2a</a><br></div><div><br></div><di= v>commit b430a140c818789ed59ac538a708df67be42fc2a<br></div><div>Author: = Mikhail Teterin <<a href=3D"mailto:mi@FreeBSD.org" class=3D"defaultMail= Link">mi@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-01-20 20:29:50 = +0000<br></div><div>Commit: Mikhail Teterin <<a href=3D"mailto:mi@Fr= eeBSD.org" class=3D"defaultMailLink">mi@FreeBSD.org</a>><br></div><div>C= ommitDate: 2024-01-20 20:29:50 +0000<br></div><div><br></div><div> net-i= m/purple-gowhatsapp: add WhatsApp plugin for libpurple<br></div><div> <b= r></div><div> The bulk of the code is implemented in Go, and so some cha= llenges remain.<br></div><div> Help would be most welcome.<br></div><div= >---<br></div><div> net-im/Makefile | 1 +<b= r></div><div> net-im/purple-gowhatsapp/Makefile | 49 +++++++++= +++++++++++++++++<br></div><div> net-im/purple-gowhatsapp/distinfo = | 3 ++<br></div><div> net-im/purple-gowhatsapp/files/patch-configure = | 27 ++++++++++++++<br></div><div> net-im/purple-gowhatsapp/pkg-descr = | 5 +++<br></div><div> net-im/purple-gowhatsapp/pkg-plist = | 5 +++<br></div><div> 6 files changed, 90 insertions(+)<br></div><div>= <br></div><div>diff --git a/net-im/Makefile b/net-im/Makefile<br></div><div= >index e55c9365ebf8..63ce6b19620c 100644<br></div><div>--- a/net-im/Makefil= e<br></div><div>+++ b/net-im/Makefile<br></div><div>@@ -104,6 +104,7 @@<br>= </div><div> SUBDIR +=3D purple-discord<br></div><div> SUBDIR +=3D p= urple-facebook<br></div><div> SUBDIR +=3D purple-googlechat<br></div><d= iv>+ SUBDIR +=3D purple-gowhatsapp<br></div><div> SUBDIR +=3D purple= -mattermost<br></div><div> SUBDIR +=3D purple-plugin-pack<br></div><div= > SUBDIR +=3D purple-rocketchat<br></div><div>diff --git a/net-im/purpl= e-gowhatsapp/Makefile b/net-im/purple-gowhatsapp/Makefile<br></div><div>new= file mode 100644<br></div><div>index 000000000000..c04ecd199d16<br></div><= div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/Makefile<br>= </div><div>@@ -0,0 +1,49 @@<br></div><div>+PORTNAME=3D=09purple-gowhatsapp<= br></div><div>+DISTVERSIONPREFIX=3Dv<br></div><div>+DISTVERSION=3D=091.13.0= <br></div><div>+CATEGORIES=3D=09net-im<br></div><div>+<br></div><div>+MAINT= AINER=3D=09<a href=3D"mailto:mi@aldan.algebra.com" class=3D"defaultMailLink= ">mi@aldan.algebra.com</a><br></div><div>+COMMENT=3D=09WhatsApp plugin for = libpurple<br></div><div>+WWW=3D=09=09<a href=3D"https://github.com/hoeherma= nn/purple-gowhatsapp" class=3D"defaultMailLink" target=3D"_blank" rel=3D"no= opener noreferrer" data-ik=3D"ik-secure">https://github.com/hoehermann/purp= le-gowhatsapp</a><br></div><div>+<br></div><div>+LICENSE=3D=09GPLv3<br></di= v><div>+LICENSE_FILE=3D=09${WRKSRC}/LICENSE<br></div><div>+<br></div><div>+= LIB_DEPENDS=3D=09<a href=3D"http://libpurple.so:net-im/libpurple" class=3D"= defaultMailLink" target=3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"i= k-secure">libpurple.so:net-im/libpurple</a>=09\<br></div><div>+=09=09<a hre= f=3D"http://libopusfile.so:audio/opusfile" class=3D"defaultMailLink" target= =3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"ik-secure">libopusfile.s= o:audio/opusfile</a><br></div><div>+<br></div><div>+USES=3D=09go:no_targets= cmake dos2unix<br></div><div>+<br></div><div>+OPTIONS_MULTI=3D=09=09=09DB-= backend<br></div><div>+OPTIONS_MULTI_DB-backend=3D=09SQLITE3 POSTGRES MYSQL= <br></div><div>+OPTIONS_DEFAULT=3DSQLITE3<br></div><div>+.for o in ${OPTION= S_MULTI_DB}<br></div><div>+$o_DESC=3D=09Support use of $o for storing accou= nt information<br></div><div>+.endfor<br></div><div>+<br></div><div>+USE_GI= THUB=3D=09yep...<br></div><div>+GH_ACCOUNT=3D=09hoehermann<br></div><div>+D= OS2UNIX_GLOB=3D=09CMake*.txt<br></div><div>+<br></div><div>+CMAKE_ARGS=3D= =09-DPURPLE_INCLUDE_DIRS=3D${LOCALBASE}/include/libpurple=09\<br></div><div= >+=09=09-DPURPLE_LIBRARY_DIRS=3D${LOCALBASE}/lib=09\<br></div><div>+=09=09-= DPURPLE_PLUGIN_DIR=3D${PREFIX}/lib/purple-2 \<br></div><div>+=09=09-DPURPLE= _DATA_DIR=3D${PREFIX}/share<br></div><div>+LDFLAGS+=3D=09-L${LOCALBASE}/lib= <br></div><div>+<br></div><div>+post-patch-POSTGRES-off:<br></div><div>+=09= ${REINPLACE_CMD} '/lib\/pq/d' ${WRKSRC}/src/go/login.go<br></div><div>+<br>= </div><div>+post-patch-MYSQL-off:<br></div><div>+=09${REINPLACE_CMD} '/go-s= ql-driver\/mysql/d' ${WRKSRC}/src/go/login.go<br></div><div>+<br></div><div= >+post-patch-SQLIT3-off:<br></div><div>+=09${REINPLACE_CMD} '/mattn\/go-sql= ite3/d' ${WRKSRC}/src/go/login.go<br></div><div>+<br></div><div>+# The down= loaded Go-files are read-only and the simple rm -f does not work<br></div><= div>+# against them (unless invoked as root). Here we relax the permissions= first:<br></div><div>+pre-clean:<br></div><div>+=09-@${FIND} ${WRKDIR} | $= {XARGS} ${CHMOD} u+w<br></div><div>+<br></div><div>+.include <<a href=3D= "http://bsd.port.mk>" class=3D"defaultMailLink" target=3D"_blank" rel=3D"no= opener noreferrer" data-ik=3D"ik-secure">bsd.port.mk></a>;<br></div><div= >diff --git a/net-im/purple-gowhatsapp/distinfo b/net-im/purple-gowhatsapp/= distinfo<br></div><div>new file mode 100644<br></div><div>index 00000000000= 0..440dd580ed44<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purp= le-gowhatsapp/distinfo<br></div><div>@@ -0,0 +1,3 @@<br></div><div>+TIMESTA= MP =3D 1705716803<br></div><div>+SHA256 (hoehermann-purple-gowhatsapp-v1.13= .0_GH0.tar.gz) =3D 153229acd476ff1f98497074402944869c73e85ad06d6cfa8529bf48= 61960c96<br></div><div>+SIZE (hoehermann-purple-gowhatsapp-v1.13.0_GH0.tar.= gz) =3D 140285<br></div><div>diff --git a/net-im/purple-gowhatsapp/files/pa= tch-configure b/net-im/purple-gowhatsapp/files/patch-configure<br></div><di= v>new file mode 100644<br></div><div>index 000000000000..b8775407932d<br></= div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/files/p= atch-configure<br></div><div>@@ -0,0 +1,27 @@<br></div><div>+--- CMakeLists= .txt=092023-09-01 16:15:26.000000000 -0400<br></div><div>++++ CMakeLists.tx= t=092024-01-19 21:50:01.130852000 -0500<br></div><div>+@@ -4,3 +4,2 @@<br><= /div><div>+ <br></div><div>+ set(Purple_DIR "${CMAKE_CURRENT_SOURCE_DIR}/su= bmodules/purple-cmake" CACHE PATH "Where to find purple-config.cmake")<br><= /div><div>+-find_package(Purple REQUIRED)<br></div><div>+@@ -41,4 +40,2 @@<= br></div><div>+ <br></div><div>+ install(DIRECTORY "pixmaps" DESTINATION "$= {PURPLE_DATA_DIR}" FILES_MATCHING PATTERN "*.png")<br></div><div>+-<br></di= v><div>+-include(cpack.cmake)<br></div><div>+--- src/go/<a href=3D"http://g= o.mod.in" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener noref= errer" data-ik=3D"ik-secure">go.mod.in</a>=092023-09-01 16:15:26.000000000 = -0400<br></div><div>++++ src/go/<a href=3D"http://go.mod.in" class=3D"defau= ltMailLink" target=3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"ik-sec= ure">go.mod.in</a>=092024-01-19 23:14:27.315646000 -0500<br></div><div>+@@ = -2,13 +2,2 @@<br></div><div>+ <br></div><div>+ go 1.18<br></div><div>+-<br>= </div><div>+-require (<br></div><div>+-=09<a href=3D"http://github.com/alfg= /mp4" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener noreferre= r" data-ik=3D"ik-secure">github.com/alfg/mp4</a> v0.0.0-20210728035756-55ea= 58c08aeb<br></div><div>+-=09<a href=3D"http://github.com/go-sql-driver/mysq= l" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener noreferrer" = data-ik=3D"ik-secure">github.com/go-sql-driver/mysql</a> v1.6.0<br></div><d= iv>+-=09<a href=3D"http://github.com/lib/pq" class=3D"defaultMailLink" targ= et=3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"ik-secure">github.com/= lib/pq</a> v1.10.4<br></div><div>+-=09<a href=3D"http://github.com/mattn/go= -sqlite3" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener noref= errer" data-ik=3D"ik-secure">github.com/mattn/go-sqlite3</a> v1.14.10<br></= div><div>+-=09<a href=3D"http://github.com/mdp/qrterminal/v3" class=3D"defa= ultMailLink" target=3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"ik-se= cure">github.com/mdp/qrterminal/v3</a> v3.0.0<br></div><div>+-=09<a href=3D= "http://github.com/skip2/go-qrcode" class=3D"defaultMailLink" target=3D"_bl= ank" rel=3D"noopener noreferrer" data-ik=3D"ik-secure">github.com/skip2/go-= qrcode</a> v0.0.0-20200617195104-da1b6568686e<br></div><div>+-=09<a href=3D= "http://golang.org/x/net" class=3D"defaultMailLink" target=3D"_blank" rel= =3D"noopener noreferrer" data-ik=3D"ik-secure">golang.org/x/net</a> v0.5.0 = <br></div><div>+-=09<a href=3D"http://go.mau.fi/whatsmeow" class=3D"default= MailLink" target=3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"ik-secur= e">go.mau.fi/whatsmeow</a> latest<br></div><div>+-)<br></div><div>diff --gi= t a/net-im/purple-gowhatsapp/pkg-descr b/net-im/purple-gowhatsapp/pkg-descr= <br></div><div>new file mode 100644<br></div><div>index 000000000000..89e60= 1b1a08d<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowha= tsapp/pkg-descr<br></div><div>@@ -0,0 +1,5 @@<br></div><div>+A libpurple/Pi= dgin plugin for WhatsApp.<br></div><div>+<br></div><div>+This is a re-write= of purple-gowhatsapp, switching back-ends from<br></div><div>+go-whatsapp = to whatsmeow. whatsmeow is written by Tulir Asokan. It<br></div><div>+has m= ulti-device support.<br></div><div>diff --git a/net-im/purple-gowhatsapp/pk= g-plist b/net-im/purple-gowhatsapp/pkg-plist<br></div><div>new file mode 10= 0644<br></div><div>index 000000000000..b4b08ff3d299<br></div><div>--- /dev/= null<br></div><div>+++ b/net-im/purple-gowhatsapp/pkg-plist<br></div><div>@= @ -0,0 +1,5 @@<br></div><div>+lib/purple-2/<a href=3D"http://libwhatsmeow.s= o" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener noreferrer" = data-ik=3D"ik-secure">libwhatsmeow.so</a><br></div><div>+share/pixmaps/pidg= in/protocols/16/whatsapp.png<br></div><div>+share/pixmaps/pidgin/protocols/= 22/whatsapp.png<br></div><div>+share/pixmaps/pidgin/protocols/48/whatsapp.p= ng<br></div><div>+share/pixmaps/pidgin/protocols/64/whatsapp.png<br></div><= /pre></blockquote></div><div><div>Hi,<br></div><div><div><br></div></div><d= iv>Please at least enable DEVELOPER=3Dyes and fix any warnings<br></div><di= v><div><br></div></div><div>Use the standard definition for POSTGRES, PGSQL= <br></div><div><a href=3D"https://cgit.freebsd.org/ports/tree/Mk/bsd.option= s.desc.mk#n410" target=3D"_blank" rel=3D"noopener noreferrer" data-ik=3D"ik= -secure">https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410</a= ><br></div><div><div><br></div></div><div>SQLITE option is broken<br></div>= <div>"post-patch-SQLIT3-off"<br></div><div><div><br></div></div><div>Overal= l ordering in Makefile can be improved, LDFLAGS can probably be replaced wi= th USES=3D localbase:ldflags<br></div><div><div><br></div><div>Configure lo= gs suggests that USES=3D pkgconfig should be added<br></div><div><br></div>= </div><div>It also fails to build<br></div><div><div><br></div></div><div><= a href=3D"https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/lo= gs/errors/purple-gowhatsapp-1.13.0.log" target=3D"_blank" rel=3D"noopener n= oreferrer" data-ik=3D"ik-secure">https://pdr2.bofh.network/data/140-diizzy/= 2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log</a><br></div>= <div><div><br></div></div><div>If you're unsure please consider to create a= review / PR instead of just committing.<br></div><div><div><br></div></div= ><div>Please back this out for now.<br></div><div><div><br></div></div><div= >Best regards,<br></div><div>Daniel<br></div></div> --_=_swift_1705788942_509e858d642a423d08522cc13518fa7f_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f22ba5fb94cbee57ef6dbac2bdb3db87>