Date: Wed, 5 Sep 2007 08:56:25 -0400 (EDT) From: Daniel Eischen <deischen@freebsd.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>, John Baldwin <jhb@freebsd.org> Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h Message-ID: <Pine.GSO.4.64.0709050846230.4952@sea.ntplx.net> In-Reply-To: <20070904122356.GN30502@comp.chem.msu.su> References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> <Pine.GSO.4.64.0708281256150.3757@sea.ntplx.net> <200708281403.05931.jhb@freebsd.org> <Pine.GSO.4.64.0708281600430.3757@sea.ntplx.net> <20070829073011.GD598@comp.chem.msu.su> <Pine.GSO.4.64.0708290953270.8772@sea.ntplx.net> <20070830061935.GF31948@comp.chem.msu.su> <Pine.GSO.4.64.0708300355570.12771@sea.ntplx.net> <20070904111400.GM30502@comp.chem.msu.su> <20070904122356.GN30502@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Sep 2007, Yar Tikhiy wrote: > > I must withdraw my argument against alias versions. My problem > with them appeared to stem from a typo in "__weak_reference" I'd > inherited from your example. :-) > It's funny that the compiler emitted just a vague warning: > > foo.c:12: warning: data definition has no type or storage class > foo.c:12: warning: parameter names (without types) in function declaration > > and the typo remained unnoticed until I saw it by accident. > > Now I'll investigate if macros can help us to have right versions > in branches and HEAD... Do you think there is a non-hackish way > to see if we're on a STABLE branch? __FreeBSD_version doesn't seem > to provide the information until after the first release from the > branch has been cut. I can't think of anything. The other problem is that we may need to MFC an ABI change before -current is branched. When that happens, the RELENG_X version (FBSD_1.?) also needs to exist in -current. Other ABI changes in -current should remain in the hidden or temporary (or whatever we call it) version. I'm still unconvinced that this method is worth the effort or confusion level ;-) > OTOH, we should't dump ObsoleteVersions completely because we may > need it, too, e.g., when we didn't plan to break an ABI twice in a > row but have to. OK, but I suppose you could just create the file when it is needed for the first time. -- DE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.0709050846230.4952>