Date: Wed, 12 Jan 2011 11:39:42 -0700 From: Warner Losh <imp@bsdimp.com> To: freebsd-mips@FreeBSD.org Subject: Re: [PATCH] Use vm_paddr_t for physical address on MIPS Message-ID: <4D2DF56E.6080207@bsdimp.com> In-Reply-To: <AANLkTiksezVkcnwvxv6Fnr9cHAnACZWCH6_jc0buy08h@mail.gmail.com> References: <AANLkTi=Ab%2BsUez%2BCH0_2=LJh5bQeRXF-Fv2C6t9-DPVy@mail.gmail.com> <AANLkTiksezVkcnwvxv6Fnr9cHAnACZWCH6_jc0buy08h@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/12/2011 04:43, Jayachandran C. wrote: > On Wed, Jan 12, 2011 at 5:08 PM, Jayachandran C. > <c.jayachandran@gmail.com> wrote: >> There are a few places in MIPS where vm_offset_t is used for physical >> addresses. The attached patch fixes them, and also contains changes to >> use uintmax_t when printing PTE entries and physical addresses. >> >> I plan to check this in if there are no objections, before checking in >> the 64 bit PTE changes. These changes will be useful if we decide to >> have 64 bit physical address on n32(32bit) compilation. > Re-sending with attachment. These changes look good to me. Looks like arm makes the same mistake about vm_offset_t vs vm_paddr_t for phys_avail too (well in places, it appears to be muddled between both depending on the subport). ia64, i386, amd64 and sparc64 get this right. powerpc uses vm_offset_t, and likely should be changed as well. Warner > JC. > > > _______________________________________________ > freebsd-mips@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D2DF56E.6080207>