Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Jul 2020 20:47:12 -0700
From:      "Simon J. Gerraty" <sjg@juniper.net>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        <src-committers@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <svn-src-head@FreeBSD.org>, <sjg@juniper.net>
Subject:   Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake
Message-ID:  <45359.1594266432@kaos.jnpr.net>
In-Reply-To: <202007090328.0693SNo4028242@slippy.cwsent.com>
References:  <202007082120.068LKCeN067904@repo.freebsd.org> <202007090328.0693SNo4028242@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Cy Schubert <Cy.Schubert@cschubert.com> wrote:
> This broke ports.

I've reverted the change.

Let me know if you still see issue.

> =

> cwsys# make checksum
> make: "/usr/ports/Mk/Uses/python.mk" line 367: warning: String compariso=
n
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/Uses/python.mk" line 367: Malformed conditional
> (!defined(_PYTHON_VERSION) &&  !(!empty(_PYTHON_VERSION_MINIMUM) && (
> ${__VER} < ${_PYTHON_VERSION_MINIMUM})) &&  !(!empty(_PYTHON_VERSION_MAX=
IMUM
> ) && (  ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
> make: "/usr/ports/Mk/Uses/python.mk" line 367: warning: String compariso=
n
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/Uses/python.mk" line 367: Malformed conditional
> (!defined(_PYTHON_VERSION) &&  !(!empty(_PYTHON_VERSION_MINIMUM) && (
> ${__VER} < ${_PYTHON_VERSION_MINIMUM})) &&  !(!empty(_PYTHON_VERSION_MAX=
IMUM
> ) && (  ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
> make: "/usr/ports/Mk/Uses/python.mk" line 367: warning: String compariso=
n
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/Uses/python.mk" line 367: Malformed conditional
> (!defined(_PYTHON_VERSION) &&  !(!empty(_PYTHON_VERSION_MINIMUM) && (
> ${__VER} < ${_PYTHON_VERSION_MINIMUM})) &&  !(!empty(_PYTHON_VERSION_MAX=
IMUM
> ) && (  ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
> make: "/usr/ports/Mk/Uses/python.mk" line 367: warning: String compariso=
n
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/Uses/python.mk" line 367: Malformed conditional
> (!defined(_PYTHON_VERSION) &&  !(!empty(_PYTHON_VERSION_MINIMUM) && (
> ${__VER} < ${_PYTHON_VERSION_MINIMUM})) &&  !(!empty(_PYTHON_VERSION_MAX=
IMUM
> ) && (  ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
> make: "/usr/ports/Mk/Uses/python.mk" line 367: warning: String compariso=
n
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/Uses/python.mk" line 367: Malformed conditional
> (!defined(_PYTHON_VERSION) &&  !(!empty(_PYTHON_VERSION_MINIMUM) && (
> ${__VER} < ${_PYTHON_VERSION_MINIMUM})) &&  !(!empty(_PYTHON_VERSION_MAX=
IMUM
> ) && (  ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
> make: "/usr/ports/Mk/Uses/python.mk" line 367: warning: String compariso=
n
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/Uses/python.mk" line 367: Malformed conditional
> (!defined(_PYTHON_VERSION) &&  !(!empty(_PYTHON_VERSION_MINIMUM) && (
> ${__VER} < ${_PYTHON_VERSION_MINIMUM})) &&  !(!empty(_PYTHON_VERSION_MAX=
IMUM
> ) && (  ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
> make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison
> operator should be either =3D=3D or !=3D
> make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional
> (defined(MAKE_JOBS_NUMBER_LIMIT) && ( ${MAKE_JOBS_NUMBER_LIMIT} <
> ${_MAKE_JOBS_NUMBER} ))
> make: Fatal errors encountered -- cannot continue
> make: stopped in /usr/ports/www/firefox
> cwsys#
> =

> The same errors occur during buildworld.
> =

> Simply reverting just contrib/bmake/cond.c resolves this issue. The caus=
e of
> this issue is NetBSD cond.c r1.76, therefore it is safe to revert just t=
he
> one file without reverting the complete upgrade.
> =

> https://urldefense.com/v3/__http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.=
bin/make/cond.c?rev=3D1.76&content-type=3Dtext*x-cvsweb-markup&only_with_t=
ag=3DMAIN__;Lw!!NEt6yMaO-gk!VltPNuPO6XKkx3hxHjCA98ZeFCqyVtHYuLQi8D1AE6HcNI=
FdwIRm80hIxRvmDA$
> =

> =

> --
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://urldefense.com/v3/__http=
s://FreeBSD.org__;!!NEt6yMaO-gk!VltPNuPO6XKkx3hxHjCA98ZeFCqyVtHYuLQi8D1AE6=
HcNIFdwIRm80gLfK9-dg$
> NTP:           <cy@nwtime.org>    Web:  https://urldefense.com/v3/__http=
s://nwtime.org__;!!NEt6yMaO-gk!VltPNuPO6XKkx3hxHjCA98ZeFCqyVtHYuLQi8D1AE6H=
cNIFdwIRm80gVslaffA$
> =

>         The need of the many outweighs the greed of the few.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45359.1594266432>