Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Aug 2023 16:43:02 -0300
From:      Joseph Mingrone <jrm@FreeBSD.org>
To:        Renato Botelho <garga@FreeBSD.org>
Cc:        Po-Chuan Hsieh <sunpoet@FreeBSD.org>,  ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,  dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 11e51925413b - main - devel/p5-DateTime-Format-MySQL: Update to 0.08
Message-ID:  <86v8dcnnll.fsf@phe.ftfl.ca>
In-Reply-To: <440dbd8c-04e1-4c5f-a4de-bd11cd8f0cac@FreeBSD.org> (Renato Botelho's message of "Fri, 18 Aug 2023 16:01:54 -0300")
References:  <202308161836.37GIaHp6043137@gitrepo.freebsd.org> <ec2e809f-9b65-46cb-b4fc-cacd287c5a83@FreeBSD.org> <86jzttx00m.fsf@phe.ftfl.ca> <a1c25f10-8198-4c67-891d-aa6a9ce5ae02@FreeBSD.org> <867cpsp4hi.fsf@phe.ftfl.ca> <440dbd8c-04e1-4c5f-a4de-bd11cd8f0cac@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Fri, 2023-08-18 at 16:01, Renato Botelho <garga@FreeBSD.org> wrote:

> On 18/08/23 15:52, Joseph Mingrone wrote:
>> On Fri, 2023-08-18 at 14:32, Renato Botelho <garga@FreeBSD.org> wrote:

>>> On 17/08/23 10:37, Joseph Mingrone wrote:
>>>> On Thu, 2023-08-17 at 10:15, Renato Botelho <garga@FreeBSD.org> wrote:

>>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote:
>>>>>> The branch main has been updated by sunpoet:
>>>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=11e51925413b7090544d4a4ac449c364717f7e50
>>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50
>>>>>> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>>>>>> AuthorDate: 2023-08-16 18:16:29 +0000
>>>>>> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>>>>>> CommitDate: 2023-08-16 18:26:21 +0000
>>>>>>        devel/p5-DateTime-Format-MySQL: Update to 0.08
>>>>>>             Changes:        https://metacpan.org/dist/DateTime-Format-MySQL/changes
>>>>>> ---
>>>>>>     devel/p5-DateTime-Format-MySQL/Makefile | 2 +-
>>>>>>     devel/p5-DateTime-Format-MySQL/distinfo | 6 +++---
>>>>>>     2 files changed, 4 insertions(+), 4 deletions(-)
>>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> index 989d481a74d2..f9b0e03be278 100644
>>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> @@ -1,5 +1,5 @@
>>>>>>     PORTNAME=	DateTime-Format-MySQL
>>>>>> -PORTVERSION=	0.0701
>>>>>> +PORTVERSION=	0.08

>>>>> Hello Po-Chuan!

>>>>> 0.08 is smaller than 0.0701 so port version went backwards after this change.
>>>> 0.08 is greater than 0.0701, but not according to pkg version.
>>>> 	% pkg version -t 0.08 0.0701
>>>>           <

>>> Actually pkg is correct in this case.  Numerically 8 is smaller than 701.  I tested it on Ubuntu and dpkg --compare-versions has the same result, and I believe any other package management tool will do.

>>> What seems to be wrong is the version schema used by this project.  It should be 0.0800 instead of 0.08.
>> I didn't mean to suggest that pkg is wrong, but just pointing out that numerically, 0.08, which is equal to 0.0800, is greater than 0.0701.  This could be a source of confusion for anyone who assumes that the comparison of version numbers works the same as comparisons of
>> real numbers.

> Right, but I cannot see how could 0.08 be considered equal to 0.0800. For me they are clearly different.  I never saw a place where adding zeroes on the right side of a number wouldn't change that number.

 % cat ./test.c
#include <stdio.h>

int
main()
{
        double a = 0.08;
        double b = 0.0800;

        if (a == b)
                printf("Phewww!\n");
        else
                printf("We're in trouble.\n");

        return (0);
}

% clang test.c -o test
% ./test
Phewww!

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----

iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmTfycZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1
QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl
YnNkLm9yZwAKCRA2pAyDsNbvnn6pD/95S+cSkWY7s02ofe9AKVXcBpV87DlHClwO
WjRI99Ft7eqPwEO0gwKovgNhx0NvkhbT51eaPOWAXThn+OTyPLOm/SIOA0+ycwQ5
DaD6Au65xknPJkoHCwTXBeuXMAdd8Umn61fp5WkeYPW58VFo0hms5UrlmmfrdpFz
ohohCSb3qd4GjWeRdgPSFPZ1LO1XSXtxr3JaXSmBITQtXwrl6OWMyJPjL4Hrk9EH
HWIfS9VMU3bAO/sKjbN4PI00uuvbeW+W9AYOVERrKYt1GUvXu75SwTRLUoDOGBxA
6mzzMgKpiBNvzc96m8wdYchwPix9R95oVEueFlqfVRrTWiOL0AkYVIzDjIX2BF3n
VkDX4Ae8BsWAwgP3b06RXpdArMwuTt4wXqG8tsOyGk3p/3RApddpoFoIEOznpLn9
/MPgNzFTZNJ9kdGJ57Z/0tb/HSYojZzud3UjuoLtqPcRySbrcPoBFVj5ZDDo+Ttd
500OOdI3KYAp6uBDuhKMYsvWEuo8uV2TMhPQWYnESvvfZW9iFYQCsZXQjSMTlm2x
RhXK3WYQAFiTiA76ERCPWMgu9UE+Z3/+tGIDXFH6F2u9cjPPOPIsulWGhClCAzc9
W/HGTuixTk7m0GxPf4vVCArJgSklu8C/HN1c3Jpcuel44xFfSGMzL6iBsfMh1J5+
/zZDedO34A==
=KRqM
-----END PGP SIGNATURE-----
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86v8dcnnll.fsf>