Date: Sun, 31 Dec 2006 09:10:17 GMT From: "Jonathan Liu" <Net147@hotmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/107368: [ports] [normalize] [patch] - normalize-mp3 and normalize-ogg don't work Message-ID: <200612310910.kBV9AHPc098598@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/107368; it has been noted by GNATS.
From: "Jonathan Liu" <Net147@hotmail.com>
To: <bug-followup@FreeBSD.org>,
<Net147@hotmail.com>
Cc:
Subject: Re: ports/107368: [ports] [normalize] [patch] - normalize-mp3 and normalize-ogg don't work
Date: Sun, 31 Dec 2006 19:53:25 +1100
This is a multi-part message in MIME format.
------=_NextPart_000_0005_01C72D15.557B3710
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
It appears that the port does a compile-time check for available programs to
use and sets the encoder and decoder programs accordingly in the
normalize-mp3 Perl script. This functionality however, seems somewhat
broken. Run-time detection of encoders and decoders should be used instead.
The following patch updates the Makefile for the port to use run-time
detection of encoders and decoders (please disregard originally submitted
patch when using this patch):
--- Makefile.orig Mon Jan 30 23:33:07 2006
+++ Makefile Sun Dec 31 19:44:27 2006
@@ -29,12 +29,14 @@
.include <bsd.port.pre.mk>
+CONFIGURE_ARGS+=--disable-helper-search
+
.if defined(WITH_XMMS)
LIB_DEPENDS+= xmms.4:${PORTSDIR}/multimedia/xmms
PLIST_SUB+= XMMS=""
PLIST_SUB+= X11BASE="${X11BASE}"
.else
-CONFIGURE_ARGS= --disable-xmms
+CONFIGURE_ARGS+=--disable-xmms
PLIST_SUB+= XMMS="@comment "
.endif
------=_NextPart_000_0005_01C72D15.557B3710
Content-Type: text/html;
charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" =
xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns=3D"http://www.w3.org/TR/REC-html40">;
<head>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<meta name=3DGenerator content=3D"Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:Arial;
color:windowtext;}
@page Section1
{size:595.3pt 841.9pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=3DEN-AU link=3Dblue vlink=3Dpurple>
<div class=3DSection1>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>It appears that the port does a compile-time check =
for
available programs to use and sets the encoder and decoder programs =
accordingly
in the normalize-mp3 Perl script. This functionality however, seems =
somewhat
broken. Run-time detection of encoders and decoders should be used =
instead. The
following patch updates the Makefile for the port to use run-time =
detection of
encoders and decoders (please disregard originally submitted patch when =
using
this patch):<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>--- Makefile.orig Mon Jan 30 23:33:07 =
2006<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>+++ Makefile Sun Dec 31 =
19:44:27 2006<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>@@ -29,12 +29,14 @@<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> <o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> .include =
<bsd.port.pre.mk><o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> <o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>+CONFIGURE_ARGS+=3D--disable-helper-search<o:p></o:p><=
/span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>+<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> .if =
defined(WITH_XMMS)<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> LIB_DEPENDS+=3D &nb=
sp; =
xmms.4:${PORTSDIR}/multimedia/xmms<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> PLIST_SUB+=3D =
XMMS=3D""<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> PLIST_SUB+=3D =
X11BASE=3D"${X11BASE}"<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> .else<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>-CONFIGURE_ARGS=3D =
--disable-xmms<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'>+CONFIGURE_ARGS+=3D--disable-xmms<o:p></o:p></span></f=
ont></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> PLIST_SUB+=3D XMMS=3D"@comment =
"<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'> .endif<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span =
style=3D'font-size:10.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
</div>
</body>
</html>
------=_NextPart_000_0005_01C72D15.557B3710--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612310910.kBV9AHPc098598>