Date: Tue, 9 Apr 2019 22:40:50 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: John Baldwin <jhb@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346063 - head/sys/dev/acpica Message-ID: <a012f864-fc2f-8729-6fa9-abe5ae4384d3@FreeBSD.org> In-Reply-To: <201904091922.x39JM8K1048972@repo.freebsd.org> References: <201904091922.x39JM8K1048972@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/04/2019 22:22, John Baldwin wrote: > Author: jhb > Date: Tue Apr 9 19:22:08 2019 > New Revision: 346063 > URL: https://svnweb.freebsd.org/changeset/base/346063 > > Log: > Don't pre-reserve resources for CPU devices when they are set. > > CPUs can use shared (RF_SHAREABLE) resources for the I/O port used for > entering and exiting C states. If this I/O port is included in an ACPI > system resource device, then this happens to still work, but if the port > wasn't part of a system resource device, only the first CPU could allocate > the I/O port and use C states since resource_list_reserve() was always > allocating the resource from nexus0 without RF_SHAREABLE. By avoiding > the reservation, the flags from the bus_alloc_resource() in the CPU driver > (which include RF_SHAREABLE) are honored. > > PR: 236513 > Reported by: stockhausen@collogia.de > Sleuthing by: avg Actually, 80-90% of it was done by the reporter. I just pieced it together :) > Reviewed by: avg > MFC after: 2 weeks -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a012f864-fc2f-8729-6fa9-abe5ae4384d3>