Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Sep 2014 22:57:12 +0000 (UTC)
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r272051 - head/sys/dev/cxgbe
Message-ID:  <201409232257.s8NMvCL3070254@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: np
Date: Tue Sep 23 22:57:11 2014
New Revision: 272051
URL: http://svnweb.freebsd.org/changeset/base/272051

Log:
  cxgbe(4):  Verify that the addresses in if_multiaddrs really are multicast
  addresses.  (The chip doesn't really care, it's just that it needs to be
  told explicitly if unicast DMACs are checked for "hits" in the hash that
  is used after the TCAM entries are all used up).

Modified:
  head/sys/dev/cxgbe/t4_main.c

Modified: head/sys/dev/cxgbe/t4_main.c
==============================================================================
--- head/sys/dev/cxgbe/t4_main.c	Tue Sep 23 22:38:10 2014	(r272050)
+++ head/sys/dev/cxgbe/t4_main.c	Tue Sep 23 22:57:11 2014	(r272051)
@@ -3031,8 +3031,10 @@ update_mac_settings(struct ifnet *ifp, i
 		TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) {
 			if (ifma->ifma_addr->sa_family != AF_LINK)
 				continue;
-			mcaddr[i++] =
+			mcaddr[i] =
 			    LLADDR((struct sockaddr_dl *)ifma->ifma_addr);
+			MPASS(ETHER_IS_MULTICAST(mcaddr[i]));
+			i++;
 
 			if (i == FW_MAC_EXACT_CHUNK) {
 				rc = t4_alloc_mac_filt(sc, sc->mbox, viid, del,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409232257.s8NMvCL3070254>