Date: Mon, 29 May 2000 01:10:25 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Warner Losh <imp@village.org> Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aic7xxx Makefile Message-ID: <Pine.BSF.4.21.0005290023480.414-100000@besplex.bde.org> In-Reply-To: <200005272256.QAA01090@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 27 May 2000, Warner Losh wrote:
> In message <20000527150542.A1535@dragon.nuxi.com> "David O'Brien" writes:
> : On Sat, May 27, 2000 at 03:45:45PM -0600, Warner Losh wrote:
> : > Shouldn't we be using the same tests we use in bsd.kmod.mk and use
> : > ${SYSDIR}/sys/*.h rather than /sys/sys/*.h? The former either exists
No. aicasm is a utility, not a module.
> :
> : "-I../.." is acutally what is used. This makes ../../sys/param.h to be
> : used over /usr/include/sys/param.h. Is there a more appropiate path to
> : use instead?
Yes. The right way is to use the compiler's default path (normally
/usr/include, but this may be overridden by buildworld).
> No. That's the right way. I should have looked at the patch first.
> Since this will only build in tree, this is the right way to fix it.
No, this way is wronger than before. The old way was almost a no-op.
It gave the compiler default of /usr/include for standalone builds,
The new way enforces a wrong include search path for standalone builds.
By "standalone" builds, I mean ones not run as part of makeworld.
buildkernel in /usr/src/Makefile.inc1 can't be part of makeworld until
makeworld builds all tools necessary to build kernels. It currently
builds at least btxldr, config, elf2exe, genassym and gensetdefs, but
not aicasm.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0005290023480.414-100000>