Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 08 Jan 2008 20:07:18 +0100
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        pav@FreeBSD.org
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c
Message-ID:  <86ejcsnnkp.fsf@ds4.des.no>
In-Reply-To: <1199818149.74596.150.camel@ikaros.oook.cz> (Pav Lucistnik's message of "Tue\, 08 Jan 2008 19\:49\:09 %2B0100")
References:  <200801080800.m08806jI012963@repoman.freebsd.org> <1199816405.74596.136.camel@ikaros.oook.cz> <86ir24nokg.fsf@ds4.des.no> <1199818149.74596.150.camel@ikaros.oook.cz>

next in thread | previous in thread | raw e-mail | index | archive | help
Pav Lucistnik <pav@FreeBSD.org> writes:
> BTW are you planning to do a __FreeBSD_version change for this unzip
> import? So we have something to .if around in bsd.port.mk in future...

Not until libarchive has learned to handle those last four zipfiles.
There are other things that need to change as well; for instance, the
current USE_ZIP code will consider the dependency satisfied if e.g.
/usr/bin/unzip exists, yet hardcodes ${LOCALBASE}/bin/unzip in
do-extract, so if I connected src/usr.bin/unzip to the build without
first changing bsd.ports.mk, all the USE_ZIP ports would break.

Apart from these four files, by the way, the difficulty lies in the
hairy command-line syntax (to avoid changing the ports) and the need to
perform ceratin manipulations like lowercasing the name of each file as
you extract it or converting DOS line endings on the fly.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ejcsnnkp.fsf>