Date: Tue, 17 Jan 2012 19:10:31 +0200 From: Jaakko Heinonen <jh@FreeBSD.org> To: Kevin Lo <kevlo@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230252 - head/sys/fs/tmpfs Message-ID: <20120117171031.GA2316@a91-153-116-96.elisa-laajakaista.fi> In-Reply-To: <201201170125.q0H1PrlJ061058@svn.freebsd.org> References: <201201170125.q0H1PrlJ061058@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-01-17, Kevin Lo wrote:
> Return EOPNOTSUPP since we only support update mounts for NFS export.
>
> @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp)
> return (EINVAL);
>
> if (mp->mnt_flag & MNT_UPDATE) {
> + /*
> + * Only support update mounts for NFS export.
> + */
> if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0))
> return (0);
> + return (EOPNOTSUPP);
> }
This doesn't look correct. As long as the option list includes the
"export" option, all options are accepted. An example:
# mount -u -o ro /mnt
mount: tmpfs : Operation not supported
# mount -u -o ro,export /mnt
#
--
Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120117171031.GA2316>