Date: Fri, 03 Nov 2006 16:34:20 -0500 From: Randall Stewart <rrs@cisco.com> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp_asconf.c Message-ID: <454BB5DC.4030903@cisco.com> In-Reply-To: <454BB06E.40202@cisco.com> References: <200611031948.kA3JmuZ6072620@repoman.freebsd.org> <454BAEF0.6050807@FreeBSD.org> <454BB06E.40202@cisco.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Randall Stewart wrote: >> > Well... I doubt it... unless tinderbox started building with > options SCTP > shortly after I commited the SCTP code in this morning... > > I am not seeing a build problem in x86 land.. I just got a complete > cvsup now.. and made sure this all builds.. (with option SCTP)... > Ok I just went and looked at these.. I fixed easily: /src/sys/netinet/sctp_usrreq.c: In function `sctp_disconnect': /src/sys/netinet/sctp_usrreq.c:1138: warning: cast from pointer to integer of different size /src/sys/netinet/sctp_usrreq.c: In function `sctp_shutdown': /src/sys/netinet/sctp_usrreq.c:1279: warning: cast from pointer to integer of different size The above two are just a silly printf.. and casting a pointer to a (u_int)... ok.. no need for the pointer print anyway.. so I can remove it easily... /src/sys/netinet/sctp_usrreq.c: In function `sctp_optsset': /src/sys/netinet/sctp_usrreq.c:3136: warning: cast from pointer to integer of different size The above one I will have to ask if any one of you can give me a hand.. I am not a sparcy person ;-) and the line is: on_off = (mtod(m, int)); (on_off is declared as a int on_off; a few lines above it). So what is wrong with mtod() to an int and setting that int into an int variable... I knew sparc's were big into 64 bit things .. but an int to an int is a problem???? Now the other set of errors on amd (yet another platform I don't have ahh if only I could buy more toys :-0): /src/sys/compat/freebsd32/freebsd32_proto.h:396: warning: redundant redeclaration of 'sctp_peeloff' /src/sys/sys/sysproto.h:1813: warning: previous declaration of 'sctp_peeloff' was here /src/sys/compat/freebsd32/freebsd32_proto.h:397: warning: redundant redeclaration of 'sctp_generic_sendmsg' /src/sys/sys/sysproto.h:1814: warning: previous declaration of 'sctp_generic_sendmsg' was here /src/sys/compat/freebsd32/freebsd32_proto.h:398: warning: redundant redeclaration of 'sctp_generic_sendmsg_iov' /src/sys/sys/sysproto.h:1815: warning: previous declaration of 'sctp_generic_sendmsg_iov' was here /src/sys/compat/freebsd32/freebsd32_proto.h:399: warning: redundant redeclaration of 'sctp_generic_recvmsg' /src/sys/sys/sysproto.h:1816: warning: previous declaration of 'sctp_generic_recvmsg' was here *** Error code 1 Since I don't understand the compat stuff... and for that matter this is the first time I have ever copied them in there (for the commit as it said to do in kern/syscalls.master)... Is there some thing special I am supposed to do when I put these critters in here? Are they supposed to be renamed differntly in some way?? I am clueless on this one :-0 R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 <or> 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?454BB5DC.4030903>