Date: Wed, 19 Jan 2000 23:38:36 -0800 (PST) From: Bill Paul <wpaul@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/usb if_aue.c if_auereg.h if_cue.c if_cuereg.h if_kue.c if_kuereg.h ohci.c ohcireg.h ohcivar.h ugen.c uhci.c uhcireg.h uhcivar.h uhid.c uhub.c ukbd.c ums.c usb_quirks.c usb_subr.c usbdevs usbdi.c usbdi.h usbdivar.h Message-ID: <200001200738.XAA89093@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
wpaul 2000/01/19 23:38:36 PST
Modified files:
sys/dev/usb if_aue.c if_auereg.h if_cue.c if_cuereg.h
if_kue.c if_kuereg.h ohci.c ohcireg.h
ohcivar.h ugen.c uhci.c uhcireg.h
uhcivar.h uhid.c uhub.c ukbd.c ums.c
usb_quirks.c usb_subr.c usbdevs usbdi.c
usbdi.h usbdivar.h
Log:
More USB ethernet tweaks:
- Sync ohci, uhci and usbdi modules with NetBSD in order to obtain the
following improvements:
o New USBD_NO_TSLEEP flag can be used in place of UQ_NO_TSLEEP
quirk. This allows drivers to specify busy waiting only for
certain transfers (namely control transfers for reading/writing
registers and stuff).
o New USBD_FORCE_SHORT_XFER flag can be used to deal with
devices like the ADMtek Pegasus that sense the end of bulk OUT
transfers in a special way (if a transfer is exactly a multiple
of 64 bytes in size, you need to send an extra empty packet
to terminate the transfer).
o usbd_open_pipe_intr() now accepts an interval argument which
can be used to change the rate at which the interrupt callback
routine is invoked. Specifying USBD_DEFAULT_INTERVAL uses the
value specified in the device's config data, but drivers can
override it if needed.
- Change if_aue to use USBD_FORCE_SHORT_XFER for packet transmissions.
- Change if_aue, if_kue and if_cue to use USBD_NO_TSLEEP for all
control transfers. We no longer force the non-tsleep hack for
bulk transfers since these are done asynchronously anyway.
- Removed quirk entry fiddling from if_aue and if_kue since we don't
need it anymore now that we have the USBD_NO_TSLEEP flag.
- Tweak ulpt, uhid, ums and ukbd drivers to use the new arg to
usbd_open_pipe_intr().
- Add a flag to the softc struct in the ethernet drivers to indicate
when a device has been detached, and use this flag to perform
tests to prevent the drivers from trying to do control transfers
if this is the case. This is necessary because calling if_detach()
with INET6 enabled will eventually result in a call to the driver's
ioctl() routine to delete the multicast groups on the interface,
which will result in attempts to perform control transfers. (It's
possible this also happens even without INET6 support enabled.) This
is pointless since we know that if the detach method has been called,
the hardware has been unplugged.
- Changed watchdog timeout routines to just call the driver init routines
to initialize the device states without trying to close and re-open the
pipes. This is partly because we don't want to frob things at interrupt
context, but also because this doesn't seem to work right and I don't
want to panic the system just because a USB device may have stopped
responding.
- Fix aue_rxeof() to be a little smarter about detecting when a double
transfer is needed. Unfortunately, the design of the chip makes it hard
to get this exactly right. Hopefully, this will go away once either
Nick or Lennart finds the bug in the uhci driver that makes this ugly
hack necessary.
- Also sync usbdevs with NetBSD.
Revision Changes Path
1.15 +30 -27 src/sys/dev/usb/if_aue.c
1.4 +3 -1 src/sys/dev/usb/if_auereg.h
1.6 +40 -25 src/sys/dev/usb/if_cue.c
1.4 +2 -1 src/sys/dev/usb/if_cuereg.h
1.17 +14 -23 src/sys/dev/usb/if_kue.c
1.4 +2 -1 src/sys/dev/usb/if_kuereg.h
1.25 +382 -63 src/sys/dev/usb/ohci.c
1.9 +29 -2 src/sys/dev/usb/ohcireg.h
1.14 +16 -2 src/sys/dev/usb/ohcivar.h
1.32 +3 -2 src/sys/dev/usb/ugen.c
1.37 +136 -52 src/sys/dev/usb/uhci.c
1.14 +2 -2 src/sys/dev/usb/uhcireg.h
1.15 +16 -13 src/sys/dev/usb/uhcivar.h
1.26 +2 -2 src/sys/dev/usb/uhid.c
1.20 +2 -2 src/sys/dev/usb/uhub.c
1.23 +3 -2 src/sys/dev/usb/ukbd.c
1.36 +3 -2 src/sys/dev/usb/ums.c
1.21 +2 -34 src/sys/dev/usb/usb_quirks.c
1.22 +52 -26 src/sys/dev/usb/usb_subr.c
1.9 +217 -189 src/sys/dev/usb/usbdevs
1.32 +57 -42 src/sys/dev/usb/usbdi.c
1.20 +23 -11 src/sys/dev/usb/usbdi.h
1.13 +27 -23 src/sys/dev/usb/usbdivar.h
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001200738.XAA89093>