Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 May 2023 22:02:44 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: ec1e83782d9d - main - rtld: don't add extraneous -L directory when MK_TOOLCHAIN == no
Message-ID:  <202305022202.342M2ixQ040000@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=ec1e83782d9d13b427f7e935e9477e8120ec6c31

commit ec1e83782d9d13b427f7e935e9477e8120ec6c31
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-05-02 19:57:20 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-05-02 22:01:43 +0000

    rtld: don't add extraneous -L directory when MK_TOOLCHAIN == no
    
    rtld's Makefile used to add -L${LIBDIR} to LDFLAGS when MK_TOOLCHAIN was
    no.  This was done as part of a change to fix building rtld with
    MK_TOOLCHAIN == no (although I'm not sure this part was necessary).
    
    In any case as of 5f2e84015da7 libc_pic.a is built independent of the
    MK_TOOLCHAIN setting and the main part of the workaround has already
    been removed.  Remove the rest now.
    
    This reverts commit c0f5aeb0329d71e6b02379133c0c9c0145c9afea.
    
    Reviewed by:    jrtc27
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39938
---
 libexec/rtld-elf/Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libexec/rtld-elf/Makefile b/libexec/rtld-elf/Makefile
index 1f3df176992a..a132c756723f 100644
--- a/libexec/rtld-elf/Makefile
+++ b/libexec/rtld-elf/Makefile
@@ -57,9 +57,6 @@ CFLAGS+=	-fpic -DPIC $(DEBUG)
 LDFLAGS+=	-shared -Wl,-Bsymbolic -Wl,-z,defs -nostdlib -e ${RTLD_ENTRY}
 # Pull in the dependencies that we use from libc
 .include "rtld-libc/Makefile.inc"
-.if ${MK_TOOLCHAIN} == "no"
-LDFLAGS+=	-L${LIBCDIR}
-.endif
 
 VERSION_DEF=	${LIBCSRCDIR}/Versions.def
 SYMBOL_MAPS=	${RTLD_ELF_DIR}/Symbol.map



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202305022202.342M2ixQ040000>