Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Jul 2017 14:23:52 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Mark Johnston <markj@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r320918 - head/sbin/savecore
Message-ID:  <1930640.IHpqZ2aWqS@ralph.baldwin.cx>
In-Reply-To: <201707121829.v6CITPxG012102@repo.freebsd.org>
References:  <201707121829.v6CITPxG012102@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, July 12, 2017 06:29:25 PM Mark Johnston wrote:
> Author: markj
> Date: Wed Jul 12 18:29:25 2017
> New Revision: 320918
> URL: https://svnweb.freebsd.org/changeset/base/320918
> 
> Log:
>   Add a newline after the version string.
>   
>   MFC after:	3 days

I think the version string normally has a trailing \n emedded in it?  Also,
have you verified that crashinfo is still able to match the Version String
from the generated info.X file?  I think it might as it stops printing lines
once it matches the second line of the version, so I think (just reading the
awk) that it will not include the extra newline in the 'ivers' compared
against 'version' from gdb.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1930640.IHpqZ2aWqS>