Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Nov 2017 07:47:33 -0800
From:      John Baldwin <jhb@freebsd.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r325793 - head/sys/dev/pci
Message-ID:  <1911777.0IZEGYVEAQ@ralph.baldwin.cx>
In-Reply-To: <201711140505.vAE555QF042553@repo.freebsd.org>
References:  <201711140505.vAE555QF042553@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, November 14, 2017 05:05:05 AM Warner Losh wrote:
> Author: imp
> Date: Tue Nov 14 05:05:05 2017
> New Revision: 325793
> URL: https://svnweb.freebsd.org/changeset/base/325793
> 
> Log:
>   Provide pcie_link_status and pcie_link_cap convenience functions.
>   
>   Sponsored by: Netflix

Note that we already have pcie_read_config() (documented in the manpage).
With pcie_read_config() these would be one liners:

pcie_link_status() -> pcie_read_config(dev, PCIER_LINK_STA, 2);

This is what the existing hotplug code uses rather than having dedicated
functions for each PCI-e register.

New functions should be documented in pci.9.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1911777.0IZEGYVEAQ>