Date: Sat, 29 Sep 2001 05:00:03 -0700 (PDT) From: Ian Dowse <iedowse@maths.tcd.ie> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/30863: bootpd/dovend.c Win95 compatibility improvement and typos in error messages Message-ID: <200109291200.f8TC03B23801@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/30863; it has been noted by GNATS.
From: Ian Dowse <iedowse@maths.tcd.ie>
To: Dan Lukes <dan@obluda.cz>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/30863: bootpd/dovend.c Win95 compatibility improvement and typos in error messages
Date: Sat, 29 Sep 2001 12:59:19 +0100
In message <200109270142.f8R1gEH43139@xkulesh.vol.cz>, Dan Lukes writes:
>
> Win95 release ignore dn (domain-name) field unless <NUL> terminated.
>Padding shouldn't cause a problem on other systems
Hi,
The ISC dhcpd only NUL-terminates replies when it detects a Microsoft
client that requires it:
/* Set a flag if this client is a lame Microsoft client that NUL
terminates string options and expects us to do likewise. */
if (packet -> options [DHO_HOST_NAME].data &&
packet -> options [DHO_HOST_NAME].data
[packet -> options [DHO_HOST_NAME].len - 1] == '\0')
lease -> flags |= MS_NULL_TERMINATION;
else
lease -> flags &= ~MS_NULL_TERMINATION;
How easy would it be to do something like this in our bootpd instead?
ISC-dhcpd is much more actively developed and widely used than bootpd
is, so it's probably better to try and follow dhcpd's approach where
possible to avoid problems that they may have already solved.
Ian
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109291200.f8TC03B23801>