Date: Thu, 5 May 2011 11:59:09 -0400 From: Attilio Rao <attilio@freebsd.org> To: mdf@freebsd.org Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221499 - in projects/largeSMP: gnu/usr.bin/gdb/kgdb lib/libmemstat sys/amd64/acpica sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/cddl/dev/cyclic/i386 sys/cddl/dev/... Message-ID: <BANLkTik4vaT2T4gH1TSnTOKGopk4PQMV0A@mail.gmail.com> In-Reply-To: <BANLkTikNwVQdGHOr1gbpajVXfvWA1LovqA@mail.gmail.com> References: <201105051439.p45EdEgC003770@svn.freebsd.org> <BANLkTikNwVQdGHOr1gbpajVXfvWA1LovqA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/5/5 <mdf@freebsd.org>: > On Thu, May 5, 2011 at 7:39 AM, Attilio Rao <attilio@freebsd.org> wrote: >> Author: attilio >> Date: Thu May =C2=A05 14:39:14 2011 >> New Revision: 221499 >> URL: http://svn.freebsd.org/changeset/base/221499 >> >> Log: >> =C2=A0Commit the support for removing cpumask_t and replacing it directl= y with >> =C2=A0cpuset_t objects. > > I suppose it's a bit of a bikeshed issue, but I found a few of the > names a little confusing. =C2=A0I'd prefer: > > s/CPU_OVERLAP/CPU_INTERSECT > s/CPU_NAND/CPU_CLRSET (to mirror CPU_CLR) or CPU_SUBTRACT or CPU_DIFFEREN= CE > > Possibly also s/CPU_OR/CPU_SETSET or CPU_UNION. =C2=A0In general I found > the naming a bit confusing since it seemed that, though these are > declared as a set of cpus (cpuset_t) the operation names aren't > set-type operations, like UNION, INTERSECT, DIFFERENCE, etc. > > It looks like the names have been around for a while, but I suspect > they don't see much use until this branch. I really don't want to mix style changes with functionality, maybe we can tweak names later, I'm not against it. Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTik4vaT2T4gH1TSnTOKGopk4PQMV0A>