Date: Tue, 25 Feb 2014 09:47:52 -0700 From: Alan Somers <asomers@freebsd.org> To: Peter Holm <peter@holm.cc> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: My first ATF test Message-ID: <CAOtMX2hQA8SP7zXsOQHd-kAV7R8ziw12Cfz=nWQbBCaS1hS48g@mail.gmail.com> In-Reply-To: <20140225161129.GA59741@x2.osted.lan> References: <20140225161129.GA59741@x2.osted.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 25, 2014 at 9:11 AM, Peter Holm <peter@holm.cc> wrote: > In order to understand how ATF works I wrote a small test so I had > something to work with: > http://people.freebsd.org/~pho/kern_descrip_test.diff > Did I get it right? ATF-wise, it looks good. However, it's a bad idea to use random numbers in test code, except in stress tests. Random numbers result in irreproducible tests. How about replacing the body of dup2_r234131 with something like this? int fd1, fd2, ret; fd1 = open("/etc/passwd", O_RDONLY); fd2 = INT_MAX; ret = dup2(fd1, fd2); ATF_CHECK_EQ(-1, ret); ATF_CHECK_EQ(EBADF, errno); On a side note, perhaps WARNS should be set in atf.test.mk, so we won't have to set it in every other Makefile. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2hQA8SP7zXsOQHd-kAV7R8ziw12Cfz=nWQbBCaS1hS48g>